From bb744108ea27216ba0bc6fd01af0713f4419f9d9 Mon Sep 17 00:00:00 2001 From: Peter Solnica Date: Mon, 1 Dec 2025 15:21:06 +0000 Subject: [PATCH 1/4] Fix warning about preferred_cli_env --- mix.exs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mix.exs b/mix.exs index 22fe76c6..b8cf68b1 100644 --- a/mix.exs +++ b/mix.exs @@ -22,10 +22,6 @@ defmodule Sentry.Mixfile do plt_add_apps: [:mix, :ex_unit] ], test_coverage: [tool: ExCoveralls], - preferred_cli_env: [ - "coveralls.html": :test, - "test.integrations": :test - ], name: "Sentry", docs: [ extra_section: "Guides", @@ -84,6 +80,10 @@ defmodule Sentry.Mixfile do ] end + def cli do + [preferred_envs: ["coveralls.html": :test, "test.integrations": :test]] + end + defp extra_applications(:test), do: [:logger, :opentelemetry] defp extra_applications(_other), do: [:logger] From 43269c6c9b3981b092dd50b8e691f22c838adade Mon Sep 17 00:00:00 2001 From: Peter Solnica Date: Mon, 1 Dec 2025 15:25:12 +0000 Subject: [PATCH 2/4] Update logger config and fix warning --- config/config.exs | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/config/config.exs b/config/config.exs index 324ae9f7..3efdc521 100644 --- a/config/config.exs +++ b/config/config.exs @@ -13,7 +13,19 @@ if config_env() == :test do test_mode: true, traces_sample_rate: 1.0 - config :logger, backends: [] + if System.version() > "1.16.0" do + config :logger, :default_handler, false + + config :sentry, :logger, [ + {:handler, :file_log, :logger_std_h, + %{ + config: %{file: ~c"log/tests.log"}, + formatter: Logger.Formatter.new() + }} + ] + else + config :logger, backends: [] + end config :opentelemetry, span_processor: {Sentry.OpenTelemetry.SpanProcessor, []} From 14735ab9fe374e45694bbb10d5c881ef19eda8f7 Mon Sep 17 00:00:00 2001 From: Peter Solnica Date: Mon, 1 Dec 2025 15:27:19 +0000 Subject: [PATCH 3/4] Fix typing violations in client test --- test/sentry/client_test.exs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/sentry/client_test.exs b/test/sentry/client_test.exs index 74b38e47..a19c2e4b 100644 --- a/test/sentry/client_test.exs +++ b/test/sentry/client_test.exs @@ -228,11 +228,11 @@ defmodule Sentry.ClientTest do end) put_test_config( - before_send: fn event -> + before_send: fn %Event{} = event -> metadata = Map.new(Logger.metadata()) {user_id, rest_metadata} = Map.pop(metadata, :user_id) - %Event{ + %{ event | extra: Map.merge(event.extra, rest_metadata), user: Map.put(event.user, :id, user_id) From ea3a7e3782df0ae997ae78b0bde79415a2784a08 Mon Sep 17 00:00:00 2001 From: Peter Solnica Date: Mon, 1 Dec 2025 15:28:54 +0000 Subject: [PATCH 4/4] Fix warning about fixture files warning: the following files do not match any of the configured `:test_load_filters` / `:test_ignore_filters`: test/fixtures/example-umbrella-app-with-conflict/apps/app_a/lib/module_a.ex test/fixtures/example-umbrella-app-with-conflict/apps/app_b/lib/module_a.ex test/fixtures/example-umbrella-app/apps/app_a/lib/module_a.ex test/fixtures/example-umbrella-app/apps/app_b/lib/module_b.ex This might indicate a typo in a test file name (for example, using "foo_tests.exs" instead of "foo_test.exs"). See the configuration for `:test_pattern` under `mix help test` for more information. --- mix.exs | 1 + 1 file changed, 1 insertion(+) diff --git a/mix.exs b/mix.exs index b8cf68b1..25685942 100644 --- a/mix.exs +++ b/mix.exs @@ -14,6 +14,7 @@ defmodule Sentry.Mixfile do deps: deps(), elixirc_paths: elixirc_paths(Mix.env()), test_paths: test_paths(System.get_env("SENTRY_INTEGRATION")), + test_ignore_filters: [~r|/fixtures/|], dialyzer: [ flags: [:unmatched_returns, :error_handling, :extra_return], plt_file: {:no_warn, "plts/dialyzer.plt"},