chore(lint): resolve oxlint warnings

- Turn off `no-base-to-string`, as we rely on casting things to strings
  in many places after verifying that they are simple not-falsey. It
  could be worthwhile to impose better type safety on all these things
  at some point, but that is unlikely to be worth doing in the near
  term.
- Remove several unused variables. We could consider disabling this rule
  in tests specifically, since that is where it's most common to leave
  scaffolding and debugging values behind.
- Cast as types in a few cases to make our intention clear, where the
  values were actually being used safely, but not explicitly.
- Disable `require-array-sort-compare` in one case where we benefit with
  a smaller code footprint by using the implicit numeric comparison on
  `Array.sort()`.

Author: isaacs

.oxlintrc.json

@@ -66,7 +66,7 @@
         "typescript/no-redundant-type-constituents": "off",
         "typescript/restrict-template-expressions": "off",
         "typescript/await-thenable": "warn",
-        "typescript/no-base-to-string": "warn"
+        "typescript/no-base-to-string": "off"
       }
     },
     {

dev-packages/node-overhead-gh-action/lib/getOverheadMeasurements.mjs

@@ -28,6 +28,7 @@ async function getMeasurements(instrumentFile, autocannonCommand = 'yarn test:ge
     await killAppProcess();
     return result;
   } catch (error) {
+    //oxlint-disable-next-line restrict-template-expressions
     log(`Error running autocannon: ${error}`);
     await killAppProcess();
     throw error;

packages/effect/test/layer.test.ts

@@ -1,6 +1,6 @@
 import { describe, expect, it } from '@effect/vitest';
 import * as sentryCore from '@sentry/core';
-import { getClient, getCurrentScope, getIsolationScope, SDK_VERSION, SentrySpan } from '@sentry/core';
+import { getClient, getCurrentScope, getIsolationScope, SDK_VERSION } from '@sentry/core';
 import { Effect, Layer, Logger, LogLevel } from 'effect';
 import { afterEach, beforeEach, vi } from 'vitest';
 import * as sentryClient from '../src/index.client';

packages/nextjs/test/utils/dropMiddlewareTunnelRequests.test.ts

@@ -138,7 +138,6 @@ describe('dropMiddlewareTunnelRequests', () => {
   describe('skipOpenTelemetrySetup', () => {
     it('does not process spans when skipOpenTelemetrySetup is true', async () => {
       const core = await import('@sentry/core');
-      const originalGetClient = core.getClient;
       vi.spyOn(core, 'getClient').mockReturnValueOnce({
         getOptions: () => ({ skipOpenTelemetrySetup: true }),
       } as any);

packages/node-core/src/integrations/systemError.ts

@@ -46,7 +46,7 @@ export const systemErrorIntegration = defineIntegration((options: Options = {})
       const error = hint.originalException;
 
       const errorContext: SystemErrorContext = {
-        ...error,
+        ...(error as SystemErrorContext),
       };
 
       if (!client.getOptions().sendDefaultPii && options.includePaths !== true) {

packages/nuxt/src/vite/sentryVitePlugin.ts

@@ -1,8 +1,7 @@
 import type { Nuxt } from '@nuxt/schema';
-import { sentryVitePlugin } from '@sentry/vite-plugin';
 import type { ConfigEnv, Plugin, UserConfig } from 'vite';
 import type { SentryNuxtModuleOptions } from '../common/types';
-import { extractNuxtSourceMapSetting, getPluginOptions, validateDifferentSourceMapSettings } from './sourceMaps';
+import { extractNuxtSourceMapSetting, validateDifferentSourceMapSettings } from './sourceMaps';
 
 /**
  * Creates a Vite plugin that adds the Sentry Vite plugin and validates source map settings.

packages/nuxt/test/vite/sourceMaps-nuxtHooks.test.ts

@@ -112,7 +112,7 @@ describe('setupSourceMaps hooks', () => {
     it.each([
       { label: 'server (SSR) build', buildConfig: { build: { ssr: true }, plugins: [] } },
       { label: 'client build', buildConfig: { build: { ssr: false }, plugins: [] } },
-    ])('adds sentry vite plugin to vite config for $label in production', async ({ buildConfig }) => {
+    ])('adds sentry vite plugin to vite config for $label in production', async () => {
       const { setupSourceMaps } = await import('../../src/vite/sourceMaps');
       const mockNuxt = createMockNuxt({ _prepare: false, dev: false });
       const { mockAddVitePlugin, getCapturedPlugins } = createMockAddVitePlugin();

packages/remix/src/server/serverTimingTracePropagation.ts

@@ -1,4 +1,3 @@
-import type { Span } from '@sentry/core';
 import { debug, getTraceData, isNodeEnv } from '@sentry/core';
 import { DEBUG_BUILD } from '../utils/debug-build';
 import { isCloudflareEnv } from '../utils/utils';

packages/remix/test/server/serverTimingTracePropagation.test.ts

@@ -1,14 +1,15 @@
-import { getActiveSpan, getTraceData, isNodeEnv, spanToBaggageHeader, spanToTraceHeader } from '@sentry/core';
+import { getActiveSpan, getTraceData, isNodeEnv } from '@sentry/core';
 import { beforeEach, describe, expect, it, vi } from 'vitest';
 import {
   generateSentryServerTimingHeader,
   injectServerTimingHeaderValue,
 } from '../../src/server/serverTimingTracePropagation';
+import type { Span } from '@sentry/core';
 
 const mockSpan = {
   spanId: 'test-span-id',
   spanContext: () => ({ traceId: '12345678901234567890123456789012' }),
-};
+} as unknown as Span;
 const mockRootSpan = {
   spanId: 'root-span-id',
   spanContext: () => ({ traceId: '12345678901234567890123456789012' }),

packages/replay-internal/src/eventBuffer/EventBufferArray.ts

@@ -73,6 +73,7 @@ export class EventBufferArray implements EventBuffer {
 
   /** @inheritdoc */
   public getEarliestTimestamp(): number | null {
+    //oxlint-disable-next-line require-array-sort-compare
     const timestamp = this.events.map(event => event.timestamp).sort()[0];
 
     if (!timestamp) {