Commit ef0e9f1
committed
fix(core): Revert sendSession consolidation and URLSearchParams changes
Revert two optimizations that caused CI failures:
- sendSession consolidation (client.ts): The eager `session.attrs = session.attrs || {}`
added an empty `attrs` property to session aggregates, breaking node-core
httpServerIntegration tests that assert on the exact shape.
- getReportDialogEndpoint URLSearchParams (api.ts): URLSearchParams percent-encodes
the DSN value (`://` → `%3A%2F%2F`), changing output format vs the original raw
string concatenation approach. Core API tests compare exact URL strings.
Both changes were functionally equivalent at runtime but broke snapshot-style
test assertions in other packages.
Co-Authored-By: Claude claude@anthropic.com1 parent 9065e37 commit ef0e9f1
2 files changed
+31
-16
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
57 | 56 | | |
| 57 | + | |
58 | 58 | | |
59 | | - | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
60 | 64 | | |
61 | 65 | | |
62 | 66 | | |
63 | 67 | | |
64 | 68 | | |
65 | | - | |
66 | | - | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
67 | 74 | | |
68 | | - | |
69 | | - | |
| 75 | + | |
| 76 | + | |
70 | 77 | | |
71 | 78 | | |
72 | | - | |
| 79 | + | |
73 | 80 | | |
74 | 81 | | |
75 | 82 | | |
76 | | - | |
| 83 | + | |
77 | 84 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
534 | 534 | | |
535 | 535 | | |
536 | 536 | | |
537 | | - | |
538 | | - | |
539 | | - | |
540 | | - | |
541 | | - | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
542 | 553 | | |
543 | 554 | | |
544 | | - | |
545 | | - | |
546 | | - | |
547 | 555 | | |
548 | 556 | | |
549 | 557 | | |
| |||
0 commit comments