Skip to content

Commit aa2133f

Browse files
committed
Codegen updates
1 parent a21e85d commit aa2133f

File tree

2 files changed

+4
-11
lines changed

2 files changed

+4
-11
lines changed

.github/workflows/e2e-v2.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -258,15 +258,6 @@ jobs:
258258
- name: Setup Plain RN ${{ matrix.rn-version }} App
259259
run: ./dev-packages/e2e-tests/cli.mjs ${{ matrix.platform }} --create
260260

261-
# The old node has to be enabled after creating the test app
262-
# to avoid issues with the old node version
263-
- run: corepack disable
264-
- uses: actions/setup-node@v5
265-
if: ${{ matrix.rn-version == '0.69.12' }}
266-
with:
267-
package-manager-cache: false
268-
node-version: 16
269-
270261
- uses: ruby/setup-ruby@v1
271262
if: ${{ matrix.platform == 'ios' }}
272263
with:

dev-packages/e2e-tests/cli.mjs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,14 +63,14 @@ const appSourceRepo = 'https://github.com/react-native-community/rn-diff-purge.g
6363
const appRepoDir = `${e2eDir}/react-native-versions/${RNVersion}`;
6464
const appName = 'RnDiffApp';
6565
const appDir = `${appRepoDir}/${appName}`;
66-
const testAppName = `${appName}.${platform == 'ios' ? 'app' : 'apk'}`;
66+
const testAppName = `${appName}.${platform === 'ios' ? 'app' : 'apk'}`;
6767
const testApp = `${e2eDir}/${testAppName}`;
6868
const appId = platform === 'ios' ? 'org.reactjs.native.example.RnDiffApp' : 'com.rndiffapp';
6969
const sentryAuthToken = env.SENTRY_AUTH_TOKEN;
7070

7171
function runCodegenIfNeeded(rnVersion, platform, appDir) {
7272
const versionNumber = parseFloat(rnVersion.replace(/[^\d.]/g, ''));
73-
const shouldRunCodegen = platform === 'android';
73+
const shouldRunCodegen = platform === 'android' && versionNumber >= 0.80;
7474

7575
if (shouldRunCodegen) {
7676
console.log(`Running codegen for React Native ${rnVersion}...`);
@@ -84,6 +84,8 @@ function runCodegenIfNeeded(rnVersion, platform, appDir) {
8484
} catch (error) {
8585
console.error('Codegen failed:', error.message);
8686
}
87+
} else {
88+
console.log(`Skipping codegen for React Native ${rnVersion}`);
8789
}
8890
}
8991

0 commit comments

Comments
 (0)