comments for later

Author: jjbayer

src/sentry/spans/buffer.py

@@ -438,6 +438,7 @@ def flush_segments(self, now: int) -> dict[SegmentKey, FlushedSegment]:
                     }
 
                 is_segment = segment_span_id == span["span_id"]
+                # TODO(INGEST-612): Once Relay writes top-level is_segment, set top-level attribute here as well.
                 span.setdefault("attributes", {})["sentry.is_segment"] = {
                     "type": "boolean",
                     "value": is_segment,

src/sentry/spans/consumers/process_segments/convert.py

@@ -15,7 +15,7 @@
     "end_timestamp": "sentry.end_timestamp_precise",
     "event_id": "sentry.event_id",
     "hash": "sentry.hash",
-    # TODO(INGEST-612): Remove "is_remote" once Relay writes this attribute.
+    # TODO(INGEST-612): replace with "is_segment" once Relay writes `sentry.is_remote`
     "is_remote": "sentry.is_remote",
     "kind": "sentry.kind",
     "name": "sentry.name",

src/sentry/spans/consumers/process_segments/enrichment.py

@@ -60,6 +60,7 @@ def _find_segment_span(spans: list[SpanEvent]) -> SpanEvent | None:
 
     # Iterate backwards since we usually expect the segment span to be at the end.
     for span in reversed(spans):
+        # TODO(INGEST-612): Check top-level `is_segment` once Relay writes it.
         if attribute_value(span, "sentry.is_segment"):
             return span
 

src/sentry/spans/consumers/process_segments/shim.py

@@ -33,7 +33,9 @@ def make_compatible(span: SpanEvent) -> CompatibleSpan:
         "sentry_tags": _sentry_tags(span.get("attributes") or {}),
         "op": get_span_op(span),
         "exclusive_time": attribute_value(span, "sentry.exclusive_time_ms"),
-        "is_segment": bool(attribute_value(span, "sentry.is_segment")),
+        "is_segment": bool(
+            attribute_value(span, "sentry.is_segment")
+        ),  # TODO(INGEST-612): Remove once Relay writes top-level `is_segment`
     }
 
     return ret

src/sentry/spans/grouping/strategy/base.py

@@ -57,7 +57,9 @@ def get_standalone_span_group(self, span: Span) -> str:
         # compatibility with transaction events, but fall back to default
         # fingerprinting if the span doesn't have a transaction.
         if (
-            attribute_value(span, "sentry.is_segment")
+            attribute_value(
+                span, "sentry.is_segment"
+            )  # TODO(INGEST-612): Use top-level is_segment once Relay writes it.
             and (transaction := attribute_value(span, "sentry.transaction")) is not None
         ):
             result = Hash()