Skip to content

improve: Only load async workers if deps available #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jylamont wants to merge 1 commit into
base: master
Choose a base branch
from
Open

improve: Only load async workers if deps available #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/vero.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
require "rest-client"
require "zeitwerk"

module Vero
end

loader = Zeitwerk::Loader.for_gem
loader.inflector.inflect(
"api_context" => "APIContext",
Expand All @@ -19,6 +22,12 @@
"unsubscribe_api" => "UnsubscribeAPI"
)
loader.ignore("#{__dir__}/generators")

loader.push_dir("#{__dir__}/vero/workers", namespace: Vero)
loader.ignore("#{__dir__}/vero/workers/resque_worker") unless defined?(Resque)
loader.ignore("#{__dir__}/vero/workers/sidekiq_worker") unless defined?(::Sidekiq)
loader.ignore("#{__dir__}/vero/workers/sucker_punch_worker") unless defined?(SuckerPunch)

loader.setup

require "vero/railtie" if defined?(Rails)
17 changes: 0 additions & 17 deletions lib/vero/sucker_punch_worker.rb
View file
Open in desktop

This file was deleted.

8 changes: 3 additions & 5 deletions lib/vero/resque_worker.rb → lib/vero/workers/resque_worker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,8 @@ class Vero::ResqueWorker
@queue = :vero

def self.perform(api_class, domain, options)
new_options = options.transform_keys(&:to_sym)

api_class.constantize.new(domain, new_options).perform

Vero::App.log(self, "method: #{api_class}, options: #{options.to_json}, response: resque job queued")
Vero::Senders::Base.new.call(api_class, domain, options)
rescue => e
Vero::App.log(self, "method: #{api_class}, options: #{options.to_json}, response: #{e.message}")
end
end
6 changes: 3 additions & 3 deletions lib/vero/sidekiq_worker.rb → lib/vero/workers/sidekiq_worker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ class Vero::SidekiqWorker
include ::Sidekiq::Worker

def perform(api_class, domain, options)
api_class.constantize.new(domain, options).perform

Vero::App.log(self, "method: #{api_class}, options: #{options.to_json}, response: sidekiq job queued")
Vero::Senders::Base.new.call(api_class, domain, options)
rescue => e
Vero::App.log(self, "method: #{api_class}, options: #{options.to_json}, response: #{e.message}")
end
end
13 changes: 13 additions & 0 deletions lib/vero/workers/sucker_punch_worker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# frozen_string_literal: true

require "sucker_punch"

class Vero::SuckerPunchWorker
include SuckerPunch::Job

def perform(api_class, domain, options)
Vero::Senders::Base.new.call(api_class, domain, options)
rescue => e
Vero::App.log(self, "method: #{api_class}, options: #{options.to_json}, response: #{e.message}")
end
end