docs

Author: Gaetano Giunta

TODO.md

@@ -6,6 +6,7 @@
     - missing for psql? (according to slack discussion: this is impossible using psql and can only be done using a different
       driver... it might be in fact already happening when NOT using input via files...)
   + examine in detail and document the differences between running a command vs a file (eg. transaction usage)
+  + check: can the temp user drop&creates schemas for postgresql?
 
 - improve cli scripts:
   + add scripts to create and drop a schema on all servers

WHATSNEW.md

@@ -1,5 +1,11 @@
-Version 0.3 (unreleased)
-------------------------
+Version 0.3.1
+-------------
+
+- Fixed: temporary db schemas would not be dropped, at least for mariadb/mysql databases
+
+
+Version 0.3
+-----------
 
 - Improved: add confirmation question to the cli command which deletes all database data
 
@@ -8,7 +14,7 @@ Version 0.3 (unreleased)
     - allow to print output in json/yaml/php format
     - allow to execute sql commands stored in a file besides specifying them as cli option
     - all sql commands are now executed in a temporary db schema, by a corresponding temp. db user, instead of being
-      executed with the database 'root' account 
+      executed with the database 'root' account
 
 
 Version 0.2

app/config/services.yaml

@@ -133,7 +133,7 @@ services:
     # this creates a service per class whose id is the fully-qualified class name
     Db3v4l\:
         resource: '../src/*'
-        exclude: '../src/{DependencyInjection,Entity,Migrations,Tests,Kernel.php}'
+        exclude: '../src/{API,Core,Tests,Util,Kernel.php}'
 
     # controllers are imported separately to make sure services can be injected
     # as action arguments even if you don't extend any base controller class

app/src/Command/SqlExecute.php

@@ -8,7 +8,7 @@
 use Symfony\Component\Yaml\Yaml;
 use Db3v4l\API\Interfaces\TimedExecutor;
 use Db3v4l\Service\DatabaseConfigurationManager;
-use Db3v4l\Service\DatabaseSchemaManager;
+use Db3v4l\Core\DatabaseSchemaManager;
 use Db3v4l\Service\SqlExecutorFactory;
 use Db3v4l\Service\ProcessManager;
 use Db3v4l\Util\Process;
@@ -177,9 +177,9 @@ protected function createSchemas($dbList, $maxParallel)
         $schemaName = null; // $userName will be used as schema name
 
         foreach ($dbList as $dbName) {
-            $dbConnectionSpec = $this->dbManager->getDatabaseConnectionSpecification($dbName);
+            $rootDbConnectionSpec = $this->dbManager->getDatabaseConnectionSpecification($dbName);
 
-            $schemaManager = new DatabaseSchemaManager($dbConnectionSpec);
+            $schemaManager = new DatabaseSchemaManager($rootDbConnectionSpec);
             $sql = $schemaManager->getCreateSchemaSQL($userName, $password, $schemaName);
             // sadly, psql does not allow to create a db and a user using a multiple-sql-commands string,
             // and we have to resort to using temp files
@@ -188,10 +188,10 @@ protected function createSchemas($dbList, $maxParallel)
             file_put_contents($tempSQLFileName, $sql);
             $tempSQLFileNames[] = $tempSQLFileName;
 
-            $executor = $this->executorFactory->createForkedExecutor($dbConnectionSpec, 'NativeClient', false);
+            $executor = $this->executorFactory->createForkedExecutor($rootDbConnectionSpec, 'NativeClient', false);
             $process = $executor->getExecuteFileProcess($tempSQLFileName);
             $processes[$dbName] = $process;
-            $connectionSpecs[$dbName] = $dbConnectionSpec;
+            $connectionSpecs[$dbName] = $rootDbConnectionSpec;
         }
 
         $this->processManager->runParallel($processes, $maxParallel, 100);
@@ -226,15 +226,15 @@ protected function dropSchemas($dbSpecList, $maxParallel)
         $tempSQLFileNames = [];
 
         foreach ($dbSpecList as $dbName => $dbConnectionSpec) {
-            $dbConnectionSpec = $this->dbManager->getDatabaseConnectionSpecification($dbName);
+            $rootDbConnectionSpec = $this->dbManager->getDatabaseConnectionSpecification($dbName);
 
-            $schemaManager = new DatabaseSchemaManager($dbConnectionSpec);
+            $schemaManager = new DatabaseSchemaManager($rootDbConnectionSpec);
             $sql= $schemaManager->getDropSchemaSQL($dbConnectionSpec['user'], isset($dbConnectionSpec['dbname']) ? $dbConnectionSpec['dbname'] : null );
             $tempSQLFileName = tempnam(sys_get_temp_dir(), 'db3val_');
             file_put_contents($tempSQLFileName, $sql);
             $tempSQLFileNames[] = $tempSQLFileName;
 
-            $executor = $this->executorFactory->createForkedExecutor($dbConnectionSpec, 'NativeClient', false);
+            $executor = $this->executorFactory->createForkedExecutor($rootDbConnectionSpec, 'NativeClient', false);
             $process = $executor->getExecuteFileProcess($tempSQLFileName);
             $processes[$dbName] = $process;
         }

app/src/Service/DatabaseSchemaManager.php renamed to app/src/Core/DatabaseSchemaManager.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace Db3v4l\Service;
+namespace Db3v4l\Core;
 
 class DatabaseSchemaManager
 {
@@ -62,7 +62,7 @@ public function getDropSchemaSQL($userName, $schemaName = null)
         switch ($dbType) {
             case 'mysql':
                 return
-                    "DROP DATABASE IF EXISTS `$schemaName`; DROP USER '$userName'@'%';";
+                    "DROP USER '$userName'@'%'; DROP DATABASE IF EXISTS `$schemaName`;";
             case 'pgsql':
                 return
                     "DROP DATABASE IF EXISTS \"$schemaName\"; DROP USER IF EXISTS \"$userName\";";

app/src/Service/SqlExecutor/BaseExecutor.php renamed to app/src/Core/SqlExecutor/BaseExecutor.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace Db3v4l\Service\SqlExecutor;
+namespace Db3v4l\Core\SqlExecutor;
 
 abstract class BaseExecutor
 {
@@ -10,4 +10,4 @@ public function __construct(array $databaseConfiguration)
     {
         $this->databaseConfiguration = $databaseConfiguration;
     }
-}
+}

app/src/Service/SqlExecutor/Forked/Doctrine.php renamed to app/src/Core/SqlExecutor/Forked/Doctrine.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace Db3v4l\Service\SqlExecutor\Forked;
+namespace Db3v4l\Core\SqlExecutor\Forked;
 
 use Db3v4l\API\Interfaces\ForkedCommandExecutor;
 use Db3v4l\Util\Process;

app/src/Service/SqlExecutor/Forked/ForkedExecutor.php renamed to app/src/Core/SqlExecutor/Forked/ForkedExecutor.php

@@ -1,8 +1,8 @@
 <?php
 
-namespace Db3v4l\Service\SqlExecutor\Forked;
+namespace Db3v4l\Core\SqlExecutor\Forked;
 
-use Db3v4l\Service\SqlExecutor\BaseExecutor;
+use Db3v4l\Core\SqlExecutor\BaseExecutor;
 
 abstract class ForkedExecutor extends BaseExecutor
 {

app/src/Service/SqlExecutor/Forked/NativeClient.php renamed to app/src/Core/SqlExecutor/Forked/NativeClient.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace Db3v4l\Service\SqlExecutor\Forked;
+namespace Db3v4l\Core\SqlExecutor\Forked;
 
 use Db3v4l\API\Interfaces\ForkedCommandExecutor;
 use Db3v4l\API\Interfaces\ForkedFileExecutor;
@@ -99,4 +99,9 @@ protected function getDbClientTypeFromDriver($driver)
     {
         return str_replace('pdo_', '', $driver);
     }
+
+    protected function getEnv()
+    {
+        return array();
+    }
 }

app/src/Service/SqlExecutor/Forked/TimedExecutor.php renamed to app/src/Core/SqlExecutor/Forked/TimedExecutor.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace Db3v4l\Service\SqlExecutor\Forked;
+namespace Db3v4l\Core\SqlExecutor\Forked;
 
 use Db3v4l\API\Interfaces\ForkedCommandExecutor;
 use Db3v4l\API\Interfaces\ForkedFileExecutor;