Question: should I deprecate: "Menu Options" and keep only "Menu Commands"? ... [A] Yes

[ghiscoding]

Do anyone use the Menu Plugin optionItems list? I'd be surprised if anyone actually uses it, I personally never used it, and even though I'm the one who added the feature, it's a bit of a burden to maintain and now I just found out some accessibility (a11y) issues with them but I would rather not fix them. In the end, I would rather deprecate the whole thing instead. Removing this would simplify the code and that would be a lot less code to maintain on my end... but if you do use it, then I need to know!

For a code sample of what this feature looks like in Cell Menu/Context Menu, for a quick summary, we can have 2 separate lists (commands & options), the options list looks like this:

this.gridOptions = {
  contextMenu: {
    hideCloseButton: false,
    optionTitle: 'Change Effort Driven Flag', // optional, add title
    optionItems: [
      { option: true, title: 'True', iconCssClass: 'mdi mdi-check-box-outline' },
      { option: false, title: 'False', iconCssClass: 'mdi mdi-checkbox-blank-outline' },
      { divider: true, command: '', positionOrder: 60 },
    ],
    // subscribe to Context Menu onOptionSelected event (or use the "action" callback on each option)
    onOptionSelected: (e, args) => {
      // change Priority
      const dataContext = args?.dataContext;
      if (dataContext && dataContext.hasOwnProperty('priority')) {
        dataContext.priority = args.item.option;
        this.sgb.gridService.updateItem(dataContext);
      }
    },
  }
};

For an Option only list, we can see that in Example 24, we use options to build the list below, but we could have also used the commands list instead.

So do anyone use this? If not, I'll deprecate it and then remove it next year v11. If there are some developers who use it, then I guess I'll have to fix the a11y issues around this feature... but again I would rather get rid of it completely.

I'm tagging a few names, but I'm basically asking every users of SlickGrid... @jr01 @zewa666 @jano-kucera @wscherphof @anton-gustafsson @mcallegario

Please provide any objection below or thumbs up if you agree, thanks

[jano-kucera]

Our app uses only the grid's built-in core functionalities.
For context menus, we have a custom implementation, and the same goes for column picker and all the actions in the grid menu.
So as long as the grid's API still supports these operations, feel free to remove the junk around.

[jr01]

We don't use optionItems in our app — go ahead and deprecate/remove it. 👍

[wscherphof]

We don't use it as well.

[ghiscoding]

ok thanks all, the answer seems pretty clear and as I expected no one really uses it. So I'll mark it as deprecated in the next release and will remove in v11 next year.

Thanks everyone for the feedback