-
Notifications
You must be signed in to change notification settings - Fork 687
Open
Description
Currently, the Lambda function responsible for creating AWS SSM Parameter Store entries in the GitHub AWS Runners Terraform module only supports a hardcoded tag:
await putParameter(${githubRunnerConfig.ssmTokenPath}/${instance}, runnerConfig.data.encoded_jit_config, true, {
tags: [{ Key: 'InstanceId', Value: instance }],
})
Ref:
- https://github.com/github-aws-runners/terraform-aws-github-runner/blob/main/lambdas/functions/control-plane/src/scale-runners/scale-up.ts#L182
- https://github.com/github-aws-runners/terraform-aws-github-runner/blob/main/lambdas/functions/control-plane/src/scale-runners/scale-up.ts#L409
- https://github.com/github-aws-runners/terraform-aws-github-runner/blob/main/lambdas/functions/control-plane/src/scale-runners/scale-up.ts#L467
This implementation does not allow for additional custom tags to be added via environment variables or configuration. Supporting custom tags would be highly beneficial for organizations that need to:
- Track cost allocation across different teams or projects.
- Manage ownership and accountability of resources.
- Integrate with internal tagging policies for governance and automation.
Metadata
Metadata
Assignees
Labels
No labels