Skip to content

Commit 8d5eb40

Browse files
committed
incorporate additional suggestions from PR review
1 parent 930b17a commit 8d5eb40

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

docs/codeql/ql-language-reference/annotations.rst

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -517,11 +517,13 @@ were a fully extracted database at the newer commit, while reusing as much cache
517517
from the base database as possible. Ideally, analysis time is proportional to the size
518518
of the diff rather than the full codebase.
519519

520-
To achieve this, predicates are divided into *local* and *global* categories. Local
521-
predicates are evaluated separately on base and overlay data, with results combined at
522-
the frontier between local and global code. Global predicates operate on the combined
523-
data. Local predicates typically take time proportional to the diff size, while global
524-
predicates take time proportional to the full codebase.
520+
To achieve this, predicates are divided into *local* and *global* categories, with global
521+
being the default. Local predicates are evaluated independently on base and overlay data,
522+
and thus typically take time proportional to the diff size; global predicates operate on
523+
the combined data, and thus take time proportional to the full codebase. When a global
524+
predicate calls a local predicate, results from both the base and overlay evaluations of
525+
the local predicate are combined, with stale base results filtered out through a process
526+
called "discarding".
525527

526528
Overlay evaluation is primarily used internally by GitHub Code Scanning to speed up
527529
pull request analysis. Most QL developers do not need to use these annotations directly,

0 commit comments

Comments
 (0)