Skip to content

Commit b363154

Browse files
committed
C++: Delete unnecessary conjuncts after review comments.
1 parent 58a3260 commit b363154

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedAssertion.qll

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,13 +89,11 @@ private predicate parseArgument(string arg, string s, int i, Opcode opcode) {
8989
i + 1) and
9090
opcode instanceof Opcode::CompareGE
9191
or
92-
not arg.regexpMatch("([a-zA-Z_][a-zA-Z_0-9]*|[0-9]+)\\s?<=\\s?([a-zA-Z_][a-zA-Z_0-9]*|[0-9]+)") and
9392
s =
9493
arg.regexpCapture("([a-zA-Z_][a-zA-Z_0-9]*|[0-9]+)\\s?<\\s?([a-zA-Z_][a-zA-Z_0-9]*|[0-9]+)",
9594
i + 1) and
9695
opcode instanceof Opcode::CompareLT
9796
or
98-
not arg.regexpMatch("([a-zA-Z_][a-zA-Z_0-9]*|[0-9]+)\\s?>=\\s?([a-zA-Z_][a-zA-Z_0-9]*|[0-9]+)") and
9997
s =
10098
arg.regexpCapture("([a-zA-Z_][a-zA-Z_0-9]*|[0-9]+)\\s?>\\s?([a-zA-Z_][a-zA-Z_0-9]*|[0-9]+)",
10199
i + 1) and
@@ -127,7 +125,6 @@ private predicate hasVarAccessMacroArgument(MacroInvocation mi, Variable var, in
127125
exists(string arg, string s, Function f |
128126
arg = mi.getUnexpandedArgument(0) and
129127
f = getEnclosingFunctionForMacroInvocation(mi) and
130-
not exists(s.toInt()) and
131128
parseArgument(arg, s, i, opcode) and
132129
var = unique( | | getAVariableWithNameInFunction(f, s))
133130
)

0 commit comments

Comments
 (0)