C#: Exclude the field access cases from missing argument call.

michaelnebel · michaelnebel · commit df0326921b91 · 2026-01-15T19:01:40.000+01:00
diff --git a/csharp/ql/consistency-queries/DataFlowConsistency.ql b/csharp/ql/consistency-queries/DataFlowConsistency.ql
@@ -60,6 +60,12 @@ private module Input implements InputSig<Location, CsharpDataFlow> {
       qe.isConditional() and
       qe.getQualifier() = arg.asExpr()
     )
+    or
+    // TODO: Remove once underlying issue is fixed
+    exists(AssignableDefinitions::OutRefDefinition def |
+      def.getTargetAccess().(QualifiableExpr) = arg.asExpr() and
+      def.getTargetAccess().isOutArgument()
+    )
   }
 
   predicate multipleArgumentCallExclude(ArgumentNode arg, DataFlowCall call) {

Original file line number	Diff line number	Diff line change
`@@ -60,6 +60,12 @@ private module Input implements InputSig<Location, CsharpDataFlow> {`
`60`	`60`	`qe.isConditional() and`
`61`	`61`	`qe.getQualifier() = arg.asExpr()`
`62`	`62`	`)`
	`63`	`+ or`
	`64`	`+ // TODO: Remove once underlying issue is fixed`
	`65`	`+ exists(AssignableDefinitions::OutRefDefinition def \|`
	`66`	`+ def.getTargetAccess().(QualifiableExpr) = arg.asExpr() and`
	`67`	`+ def.getTargetAccess().isOutArgument()`
	`68`	`+ )`
`63`	`69`	`}`
`64`	`70`
`65`	`71`	`predicate multipleArgumentCallExclude(ArgumentNode arg, DataFlowCall call) {`