make it more clear that transient updates destroy the old value

Author: yoshie

src/dict.mjs

@@ -301,7 +301,7 @@ export function make() {
 export function from(iterable) {
   let transient = toTransient(emptyDict);
   for (const [key, value] of iterable) {
-    transient = transientInsert(key, value, transient);
+    transient = destructiveTransientInsert(key, value, transient);
   }
   return fromTransient(transient);
 }
@@ -448,7 +448,7 @@ export function insert(dict, key, value) {
  *
  * Returns a new transient.
  */
-export function transientInsert(key, value, transient) {
+export function destructiveTransientInsert(key, value, transient) {
   const hash = getHash(key);
   transient.root = doInsert(transient, transient.root, key, value, hash, 0);
   return transient;
@@ -460,7 +460,7 @@ export function transientInsert(key, value, transient) {
  *
  * Returns a new transient.
  */
-export function transientUpdateWith(key, fun, value, transient) {
+export function destructiveTransientUpdateWith(key, fun, value, transient) {
   const hash = getHash(key);
 
   const existing = lookup(transient.root, key, hash);
@@ -553,7 +553,7 @@ function doInsert(transient, node, key, value, hash, shift) {
  * Consume a transient, removing a key if it exists.
  * Returns a new transient.
  */
-export function transientDelete(key, transient) {
+export function destructiveTransientDelete(key, transient) {
   transient.root = doDelete(transient, transient.root, key, getHash(key), 0);
   return transient;
 }

src/gleam/dict.gleam

@@ -195,7 +195,7 @@ pub fn insert(into dict: Dict(k, v), for key: k, insert value: v) -> Dict(k, v)
 fn do_insert(key: k, value: v, dict: Dict(k, v)) -> Dict(k, v)
 
 @external(erlang, "maps", "put")
-@external(javascript, "../dict.mjs", "transientInsert")
+@external(javascript, "../dict.mjs", "destructiveTransientInsert")
 fn transient_insert(
   key: k,
   value: v,
@@ -373,7 +373,7 @@ pub fn delete(from dict: Dict(k, v), delete key: k) -> Dict(k, v) {
 }
 
 @external(erlang, "maps", "remove")
-@external(javascript, "../dict.mjs", "transientDelete")
+@external(javascript, "../dict.mjs", "destructiveTransientDelete")
 fn transient_delete(a: k, b: TransientDict(k, v)) -> TransientDict(k, v)
 
 /// Creates a new dict from a given dict with all the same entries except any with
@@ -558,7 +558,7 @@ fn do_combine(
 }
 
 @external(erlang, "maps", "update_with")
-@external(javascript, "../dict.mjs", "transientUpdateWith")
+@external(javascript, "../dict.mjs", "destructiveTransientUpdateWith")
 fn transient_update_with(
   key: k,
   fun: fn(v) -> v,