Lsp autocompletion no close parenthesis

[basluc]

Godot version

4.1.3

System information

Godot v4.1.2.stable - KDE neon 5.27 22.04 - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1650 (nvidia; 525.125.06) - Intel(R) Core(TM) i5-10300H CPU @ 2.50GHz (8 Threads)

Issue description

I using an external editor (Neovim). I've also tested this with Visual Studio Code. When I use autocompletion for functions, it doesn't automatically close parentheses. I've tested this on both Linux and Windows, with the latest version (4.1.3) as well as the Steam version.

If I use autocompletion with the print() function, the editor suggests the function, and when I press Enter, the autocompletion result is: print(. The same issue occurs with the append() function of an array, and the result is test.append(. Likewise with many other functions. However, in the Godot editor, there is no problem.

Steps to reproduce

I don't know how to reproduce this bug. I tested the autocompletion on someone else's Ubuntu, and there were no issues using VSCode. As mentioned above, I tested it on two different computers with different operating systems, using both VSCode with godot-tools installed and Neovim, and the bug still persists for me.

Minimal reproduction project

Any project with a GDScript script is sufficient.

[HolonProduction]

Godot auto completion only returns the opening parenthesis if the function has parameters. It relies on the client doing auto brace completion which both VSCode and the Godot Script Editor support. If it would return both opening and closing braces, the cursor would be placed after the closing brace, which would make it very hard to enter arguments.

Looks like a design constraint to me, although it would be interesting to know how other Language Servers handle this.

You should look for an auto brace completion plugin for neovim.

[basluc]

Godot auto completion only returns the opening parenthesis if the function has parameters. It relies on the client doing auto brace completion which both VSCode and the Godot Script Editor support. If it would return both opening and closing braces, the cursor would be placed after the closing brace, which would make it very hard to enter arguments.

Looks like a design constraint to me, although it would be interesting to know how other Language Servers handle this.

You should look for an auto brace completion plugin for neovim.

As mentioned in my post, I tested it on VSCode. I work with different languages, and I've never had this issue with Neovim and VSCode. So, for me, it's indeed a bug coming from the GDScript LSP. Let me clarify; I tested it on VSCode with the Godot plugin, which is well-configured since I have autocompletion that correctly detects function names. The same goes for Neovim, which correctly captures function names along with their documentation.

And it cannot be a flaw coming from a VSCode setting that does not correctly close parentheses or from my Neovim plugin that automatically closes parentheses and braces because, in a simple text file, or any other non-exotic languages, both editors correctly close them.

[salvoton]

This is extremely disturbing. The problem still persists and that's the only reason I can't use Godot. Have you found any solution?

[basluc]

This is extremely disturbing. The problem still persists and that's the only reason I can't use Godot. Have you found any solution?

I'm sorry, but the bug still persists and I haven't found any workarounds. I think our only option left is to use the mono version of Godot which uses C#. We won't have any LSP issues with C#. But, it's a shame to have to use this language instead of GDScript. Alternatively, we could use Godot's built-in tools.

[HolonProduction]

Ok I somehow remembered not being able to reproduce this, but after trying again I can (in VSCode).

I also looked at what other languages do (in VSCode). Python as well as typescript don't add parenthesis at all. I wonder if that would be better. It will probably solve problems for some people that use strict settings to prevent mismatched parens. But you would still need to type the braces yourself.

That being said I think it would make sense to align the GDScript behavior with more popular languages, to not break expectations. (Only talking about VSCode LSP, since everything works well in Godot).

[Braveo]

I came across this, and want to know if people prefer having an opening parentheses when the method is autocompleted, or prefer having to manually type out parenthesis? I prefer manually having to type it out, but I wonder if there's a way this can be an option.

I was doing a bit of experimentation with the source code and just had it so methods/functions do not autocomplete with parenthesis:

Code_BXhItYUmWj.mp4

Pull Request #96726 also addresses this by completing the parentheses, but now there's an issue of intellisense not showing the paremeters in a method, which I wonder if it's a vscode issue or a lsp issue:

Code_BdBaRRJR0k.mp4

The main reason I prefer having to manually type out the opening parenthesis is because most other languages I've used don't automatically type out the parenthesis, but I wonder if this could lead to other issues down the line, which is why I wonder if I should create a new issue or proposal regarding this, do a pull request, or contribute to reviewing Pull Request #96726. Ultimately, having it be an option would sound nice.

[theautisticone799]

is this fixed yet?? :(