dev: enable testifylint linter (#4595)

Author: alexandear

.golangci.yml

@@ -133,6 +133,7 @@ linters:
     - revive
     - staticcheck
     - stylecheck
+    - testifylint
     - unconvert
     - unparam
     - unused
@@ -213,4 +214,3 @@ issues:
 
 run:
   timeout: 5m
-

pkg/golinters/misspell_test.go

@@ -29,7 +29,7 @@ func Test_appendExtraWords(t *testing.T) {
 
 	expected := []string{"iff", "if", "cancelation", "cancellation"}
 
-	assert.Equal(t, replacer.Replacements, expected)
+	assert.Equal(t, expected, replacer.Replacements)
 }
 
 func Test_appendExtraWords_error(t *testing.T) {

pkg/result/processors/autogenerated_exclude_test.go

@@ -252,6 +252,7 @@ func Test_shouldPassIssue_error(t *testing.T) {
 
 			pass, err := p.shouldPassIssue(test.issue)
 
+			//nolint:testifylint // It's a loop and the main expectation is the error message.
 			assert.EqualError(t, err, test.expected)
 			assert.False(t, pass)
 		})

pkg/result/processors/skip_files_test.go

@@ -49,6 +49,6 @@ func TestSkipFiles(t *testing.T) {
 
 func TestSkipFilesInvalidPattern(t *testing.T) {
 	p, err := NewSkipFiles([]string{"\\o"}, "")
-	assert.Error(t, err)
+	require.Error(t, err)
 	assert.Nil(t, p)
 }