Skip to content

Commit ae0eb57

Browse files
committed
feat: adapt changes in api client
* package for geo collections changed * backend fixed behavior for dependent graph – aggregatedFact is not returned anymore JIRA: TRIVIAL risk: low
1 parent c401bbe commit ae0eb57

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/declarative_model/workspace/logical_model/dataset/dataset.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
from gooddata_api_client.model.declarative_source_fact_reference import DeclarativeSourceFactReference
2121
from gooddata_api_client.model.declarative_workspace_data_filter_column import DeclarativeWorkspaceDataFilterColumn
2222
from gooddata_api_client.model.geo_area_config import GeoAreaConfig
23-
from gooddata_api_client.model.geo_collection import GeoCollection
23+
from gooddata_api_client.model.geo_collection_identifier import GeoCollectionIdentifier
2424

2525
from gooddata_sdk.catalog.base import Base
2626
from gooddata_sdk.catalog.identifier import (
@@ -189,10 +189,11 @@ def client_class() -> type[GeoAreaConfig]:
189189
@define(auto_attribs=True, kw_only=True)
190190
class CatalogGeoCollectionIdentifier(Base):
191191
id: str
192+
kind: Optional[str] = None
192193

193194
@staticmethod
194-
def client_class() -> type[GeoCollection]:
195-
return GeoCollection
195+
def client_class() -> type[GeoCollectionIdentifier]:
196+
return GeoCollectionIdentifier
196197

197198

198199
@attr.s(auto_attribs=True, kw_only=True)

packages/gooddata-sdk/tests/catalog/test_catalog_workspace_content.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -342,9 +342,8 @@ def test_get_dependent_entities_graph(test_config):
342342
sdk = GoodDataSdk.create(host_=test_config["host"], token_=test_config["token"])
343343
response = sdk.catalog_workspace_content.get_dependent_entities_graph(workspace_id=test_config["workspace"])
344344

345-
# Includes campaign_channels_per_category pre-aggregation dataset and its aggregatedFact
346-
assert len(response.graph.edges) == 174
347-
assert len(response.graph.nodes) == 101
345+
assert len(response.graph.edges) == 172
346+
assert len(response.graph.nodes) == 98
348347

349348

350349
@gd_vcr.use_cassette(str(_fixtures_dir / "demo_get_dependent_entities_graph_from_entry_points.yaml"))

0 commit comments

Comments
 (0)