diff --git a/packages/cli/src/config/settings.test.ts b/packages/cli/src/config/settings.test.ts index 1559cbe78cb..7058a42b43c 100644 --- a/packages/cli/src/config/settings.test.ts +++ b/packages/cli/src/config/settings.test.ts @@ -371,6 +371,31 @@ describe('Settings Loading and Merging', () => { expect((settings.merged as TestSettings)['allowedTools']).toBeUndefined(); }); + it('should migrate loadMemoryFromIncludeDirectories to context.loadMemoryFromIncludeDirectories', () => { + (mockFsExistsSync as Mock).mockImplementation( + (p: fs.PathLike) => p === USER_SETTINGS_PATH, + ); + const legacySettingsContent = { + loadMemoryFromIncludeDirectories: true, + }; + (fs.readFileSync as Mock).mockImplementation( + (p: fs.PathOrFileDescriptor) => { + if (p === USER_SETTINGS_PATH) + return JSON.stringify(legacySettingsContent); + return '{}'; + }, + ); + + const settings = loadSettings(MOCK_WORKSPACE_DIR); + + expect(settings.merged.context?.loadMemoryFromIncludeDirectories).toBe( + true, + ); + expect( + (settings.merged as TestSettings)['loadMemoryFromIncludeDirectories'], + ).toBeUndefined(); + }); + it('should allow V2 settings to override V1 settings when both are present (zombie setting fix)', () => { (mockFsExistsSync as Mock).mockImplementation( (p: fs.PathLike) => p === USER_SETTINGS_PATH, diff --git a/packages/cli/src/config/settings.ts b/packages/cli/src/config/settings.ts index 3e41fbe87e9..15e448c129c 100644 --- a/packages/cli/src/config/settings.ts +++ b/packages/cli/src/config/settings.ts @@ -112,7 +112,7 @@ const MIGRATION_MAP: Record = { showCitations: 'ui.showCitations', ideMode: 'ide.enabled', includeDirectories: 'context.includeDirectories', - loadMemoryFromIncludeDirectories: 'context.loadFromIncludeDirectories', + loadMemoryFromIncludeDirectories: 'context.loadMemoryFromIncludeDirectories', maxSessionTurns: 'model.maxSessionTurns', mcpServers: 'mcpServers', mcpServerCommand: 'mcp.serverCommand',