Skip to content

Conversation

@gsehgal
Copy link
Contributor

@gsehgal gsehgal commented Nov 28, 2025

This PR will address issue 371, where we will use JSON output of Gemini CLI

Test Scenarios:

  1. Created an ISSUE which caused failure and verified the output to be in json format:
image
  1. Created a PULL request and verified the positive response was on JSON format.
image

@gsehgal gsehgal requested review from a team as code owners November 28, 2025 09:13
@MJjainam
Copy link
Collaborator

MJjainam commented Dec 1, 2025

@gemini-cli /review

@gemini-cli
Copy link

gemini-cli bot commented Dec 1, 2025

🤖 Hi @MJjainam, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

Copy link

@gemini-cli gemini-cli bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

## 📋 Review Summary

This pull request effectively refactors the action to consume the JSON output from the Gemini CLI. This is a significant improvement that allows for more robust parsing of responses and errors.

🔍 General Feedback

  • The transition to JSON output is well-implemented, with good use of jq to parse the structured data.
  • The fallback to use stderr when JSON is not available or invalid is a good defensive programming practice.
  • A few minor suggestions have been made to enhance the shell script's robustness, primarily by replacing echo with safer alternatives in specific contexts.

Copy link
Contributor Author

@gsehgal gsehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants