-
Notifications
You must be signed in to change notification settings - Fork 186
fix #371 use JSON output of gemini cli #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@gemini-cli /review |
|
🤖 Hi @MJjainam, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request effectively refactors the action to consume the JSON output from the Gemini CLI. This is a significant improvement that allows for more robust parsing of responses and errors.
🔍 General Feedback
- The transition to JSON output is well-implemented, with good use of
jqto parse the structured data. - The fallback to use
stderrwhen JSON is not available or invalid is a good defensive programming practice. - A few minor suggestions have been made to enhance the shell script's robustness, primarily by replacing
echowith safer alternatives in specific contexts.
gsehgal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed comments.
This PR will address issue 371, where we will use JSON output of Gemini CLI
Test Scenarios: