Skip to content

Commit 5a58e88

Browse files
committed
Refactored per gemini suggestions.
1 parent 25ec8a6 commit 5a58e88

File tree

2 files changed

+6
-11
lines changed

2 files changed

+6
-11
lines changed

src/google/adk/cli/cli_tools_click.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -792,12 +792,7 @@ def cli_eval(
792792
for eval_result in eval_results:
793793
eval_result: EvalCaseResult
794794

795-
should_print = (
796-
eval_result.final_eval_status != EvalStatus.PASSED
797-
or print_detailed_results_on_success
798-
)
799-
800-
if should_print:
795+
if eval_result.final_eval_status != EvalStatus.PASSED or print_detailed_results_on_success:
801796
click.echo(
802797
"********************************************************************"
803798
)

src/google/adk/evaluation/agent_evaluator.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -683,15 +683,15 @@ def _process_metrics_and_get_failures(
683683

684684
# Gather all the failures.
685685
if overall_eval_status != EvalStatus.PASSED:
686-
should_print = print_detailed_results
687686
failures.append(
688687
f"{metric_name} for {agent_module} Failed. Expected {threshold},"
689688
f" but got {overall_score}."
690689
)
691-
else:
692-
should_print = (
693-
print_detailed_results and print_detailed_results_on_success
694-
)
690+
691+
should_print = print_detailed_results and (
692+
overall_eval_status != EvalStatus.PASSED
693+
or print_detailed_results_on_success
694+
)
695695

696696
if should_print:
697697
AgentEvaluator._print_details(

0 commit comments

Comments
 (0)