-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Description
Is your feature request related to a problem? Please describe.
Currently, load_dotenv_for_agent has the following code:
load_dotenv(dotenv_file_path, override=True, verbose=True)This prevents overriding default variable values specified in .env by explicitly setting environment variables before launching ADK modules.
Describe the solution you'd like
I don't know the history of the question and why override=True was put here in the first place, maybe to allow agent .env to override properties from the root .env, but this approach has a significant adverse side effect - users can't override the variables specified in .env by exporting explicit ENVS before ADK launch.
Could this be reconsidered? It potentially would prevent issues like #3228 and #4018, and potentially may render the unconventional solution with ADK_DISABLE_LOAD_DOTENV flag unnecessary.