Skip to content

Conversation

@vfrank66
Copy link
Contributor

No description provided.

@google-cla
Copy link

google-cla bot commented Apr 16, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@vfrank66 vfrank66 force-pushed the issue-98/add-test-analyzer-to-pr branch from 8fbeb38 to d583c1d Compare April 17, 2025 02:29
uses: actions/setup-go@v5
with:
go-version: 1.22
cache: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe from reading https://github.com/actions/setup-go?tab=readme-ov-file that we don't need to explicitly add caching for this action, since as of v4 caching is the default behavior.


- name: Check out code
uses: actions/checkout@v4
cache: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the above comment, seems like this is unneeded.

- name: Get dependencies
run: |
go mod download
- name: Build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Genuine question, does this work? don't we still need to build everything for the analyzer to be able to run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants