apply feedback

Author: bennsimon

docker/compose-controller-spark-sql-external-storage.yaml

@@ -89,7 +89,7 @@ services:
       - '4041:4040'
     volumes:
       - ${DWH_ROOT}:/dwh
-      - ./drivers-build/hive-site_example.xml:/opt/bitnami/spark/conf/hive-site.xml
+      - ./hive-site_example.xml:/opt/bitnami/spark/conf/hive-site.xml
     volumes_from:
       - drivers-build
 

docker/drivers-build/Dockerfile

@@ -1,2 +1,12 @@
-FROM busybox:1.36
-COPY postgresql-42.6.0.jar /jdbcDrivers/
+FROM alpine:3.17.3
+
+WORKDIR /jdbcDrivers
+
+ARG POSTGRESQL_DRIVER_VERSION=42.6.0
+
+# Install required packages
+RUN apk update && apk add curl
+
+# Fetch drivers
+RUN curl -s https://jdbc.postgresql.org/download/postgresql-$POSTGRESQL_DRIVER_VERSION.jar \
+    -o postgresql-$POSTGRESQL_DRIVER_VERSION.jar

docker/hive-site_example.xml

@@ -17,7 +17,8 @@ https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#Config
     <!-- This setup assumes that custom_metastore_db is already created. -->
     <!-- The IP address should be adjusted based on how the thriftserver sees
       the external DB; this example is for a docker image on Linux. -->
-    <value>jdbc:postgresql://172.18.0.1:5432/custom_metastore_db</value>
+    <!-- value>jdbc:postgresql://172.18.0.1:5432/custom_metastore_db</value -->
+    <value>jdbc:postgresql://postgres:5432/custom_metastore_db</value>
     <!-- value>jdbc:postgresql://localhost:5432/custom_metastore_db</value -->
   </property>
   <property>