-
Notifications
You must be signed in to change notification settings - Fork 100
Replace global activeSurvey$ w/component inputs
#2301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to gino-m/1695/rm-id-signals
093e43d to
d4a816e
Compare
…to gino-m/2289/refactor-router
activeSurvey$ w/component inputs
…to gino-m/2289/refactor-router
Collaborator
Author
|
@rfontanarosa PTAL? |
Collaborator
Author
|
Issued identified by @rfontanarosa via Chat:
|
Merged
rfontanarosa
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR refactors multiple Ground components to use Angular Signals, enabling explicit data flow from
MainPageComponent. This change moves away from implicitSurveyServicesubscriptions to a clearer, unidirectional data flow.Changes
1. Data Flow Refactoring
ActiveSurveyservice subscriptions to explicitinput<Survey>()signals passed down fromMainPageContainerComponent.LoadSurvey$(id)and passes asurveysignal toMainPageComponent.activeSurveysignal input and passes it to children.2. Component Updates
Refactored the following components to accept
activeSurveyas aninput<Survey>()signal:jobsderived fromactiveSurvey.activeSurveyfor title.activeSurveyfor map data rendering.activeSurveytoJobListComponent.computedsignal forjobs.activeSurveyto children.surveyIdwithactiveSurvey().id.surveyIdwithactiveSurvey().id.3. Signal Propagation
The
activeSurveysignal is now propagated down the component tree:MainPageContainer->MainPage-> [Map,DrawingTools,SidePanel,SecondarySidePanel]SidePanel->JobListSecondarySidePanel-> [LoiPanel,SubmissionPanel]4. Test Updates
MapComponentspec to removeSurveyServicemock and usesetInput.LoiPanelComponent,SubmissionPanelComponent, andSecondarySidePanelComponentwith signal-based testing patterns.JobListComponentandDrawingToolsComponentspecs.Verification
Automated Tests
Run the test suite for the modified components:
npm test src/app/pages/main-page-container/main-pageManual Verification
Key Design Decisions
Generated with Antigravity.
Towards #2289
Fixed #2286.