Skip to content

Conversation

@eamonnmcmanus
Copy link
Member

No description provided.

<compilerArgs combine.self="override">
<compilerArg>-Xlint:all,-options</compilerArg>
</compilerArgs>
</configuration>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you need this as well:

Suggested change
<annotationProcessorPaths combine.self="override" />
</configuration>

Plugins specified with -Xplugin:... are loaded from the annotation processors path (see documentation). The current configuration here only removes Error Prone from <compilerArgs> but not from <annotationProcessorPaths>. So the JDK still tries to load it.

Now as for why this was not an issue for JDK 11: There was a check which returned fast if no plugins were specified. In newer JDK versions this check was intentionally removed, see the JDK-8234211 and corresponding commit.

At least that is my understanding of it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Indeed, I couldn't figure out how this had worked before.

There's a later failure in building the proto tests but I'm hoping that one will be more tractable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a later failure in building the proto tests but I'm hoping that one will be more tractable.

(That went away when I did mvn clean.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I get confused every time I see merging of configuration across pom.xml files, and I don't want to think about how long it would have taken me to figure out that that was even the right area to look.

@eamonnmcmanus eamonnmcmanus requested a review from cpovirk November 3, 2025 14:47
@eamonnmcmanus eamonnmcmanus merged commit 09fcaff into main Nov 3, 2025
23 checks passed
@eamonnmcmanus eamonnmcmanus deleted the ep21 branch November 3, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants