Skip to content

Conversation

@wsxrdv
Copy link
Collaborator

@wsxrdv wsxrdv commented Oct 27, 2025

Use uv to pip compile (freeze) dependencies.

Fixes: #266

Use uv to pip compile (freeze) dependencies.

Fixes: google#266
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @wsxrdv, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the project's Python dependency management system. It replaces the previous pip-compile workflow with uv, enabling the generation of platform-specific dependency lock files. This change aims to enhance the reliability and reproducibility of builds across different operating systems by providing tailored dependency sets, and simplifies the process for developers through an automated compilation script.

Highlights

  • Dependency Management Shift: The project has transitioned from using pip-compile to uv for freezing Python dependencies, leveraging uv's speed and efficiency.
  • Platform-Specific Requirements: Dependencies are now compiled separately for different platforms (Linux, Windows, macOS) into dedicated files, ensuring better compatibility and build reproducibility across diverse environments.
  • Automated Compilation Script: A new shell script, tools/pip_compile.sh, has been introduced to automate the process of compiling platform-specific development and production dependency files using uv.
  • Documentation Updates: The README.md and website/src/content/docs/start_here/install.mdx files have been updated with revised instructions that reflect the new uv-based, platform-specific dependency management approach.
  • Removed Legacy Dependency Files: The old requirements.txt and base-tooling-requirements.txt files have been removed, streamlining the dependency structure and eliminating redundant files.
Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/fork_pr_benchmarks_run.yml
    • .github/workflows/pytest.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request transitions the project's dependency management from pip-tools to uv, and introduces platform-specific requirement files. This is a great improvement for managing dependencies across different operating systems. The changes are well-structured, including updates to documentation and CI configuration. I have a few suggestions to improve the new scripts for better maintainability and robustness.

kralka
kralka previously approved these changes Oct 27, 2025
Copy link
Collaborator

@kralka kralka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run all workflows

@wsxrdv wsxrdv requested a review from jmichelp October 27, 2025 19:50
Copy link

@reyammer reyammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that uv would solve many of the problems you are dealing with here. But if you really need to play with pip requirements for some reason, LGTM, I don't know better ways...

# requirements.txt changes. The pinned versions in requirements.txt are
# tested by coverage since that is running on ubuntu which is also used
# to produce the main requirements.txt file.
- name: Find out Python version

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all this seems a reimplementation of what uv (or pip itself) should do. uv.lock (same for poetry) already contains all pins for all requirements for all supported architectures / python versions. I guess you need to keep all the requirements for all the combinations of OS/python version because of limitations of the pip requirements format... I'd take this opportunity to ditch pip, this seems a nightmare to properly maintain :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove workaround for pip-tools #2252

3 participants