Skip to content

chore: fix line length for code with inline mypy guard #2554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ohmayr merged 15 commits into from
Feb 2, 2026
Merged

chore: fix line length for code with inline mypy guard #2554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d161d35
chore: avoid formatting code with mypy comments
ohmayr Jan 31, 2026
f709c01
add comments
ohmayr Jan 31, 2026
70d9f45
update goldens
ohmayr Jan 31, 2026
d669568
fix typo
ohmayr Jan 31, 2026
2f61739
address feedback
ohmayr Jan 31, 2026
dbfe132
revert WORKSPACE
ohmayr Jan 31, 2026
e9615e7
address PR feedback
ohmayr Jan 31, 2026
22f7a2f
address PR feedback
ohmayr Jan 31, 2026
df24f8e
remove fmt skip from pragma NO COVER lines
ohmayr Feb 2, 2026
7d92db1
remove unnecessary fmt skips
ohmayr Feb 2, 2026
8fd1fbe
update goldens
ohmayr Feb 2, 2026
0a802ff
update goldens
ohmayr Feb 2, 2026
10a1960
fix line length
ohmayr Feb 2, 2026
20906c8
Merge branch 'main' into update-templates-to-ignore-templates
daniel-sanche Feb 2, 2026
39580a6
Trigger CI
ohmayr Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions gapic/templates/%namespace/%name_%version/%sub/services/%service/async_client.py.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,8 @@ class {{ service.async_client_name }}:
Returns:
{{ service.async_client_name }}: The constructed client.
"""
return {{ service.client_name }}.from_service_account_info.__func__({{ service.async_client_name }}, info, *args, **kwargs) # type: ignore
sa_info_func = {{ service.client_name }}.from_service_account_info.__func__ # type: ignore
return sa_info_func({{ service.async_client_name }}, info, *args, **kwargs)

@classmethod
def from_service_account_file(cls, filename: str, *args, **kwargs):
Expand All @@ -114,7 +115,8 @@ class {{ service.async_client_name }}:
Returns:
{{ service.async_client_name }}: The constructed client.
"""
return {{ service.client_name }}.from_service_account_file.__func__({{ service.async_client_name }}, filename, *args, **kwargs) # type: ignore
sa_file_func = {{ service.client_name }}.from_service_account_file.__func__ # type: ignore
return sa_file_func({{ service.async_client_name }}, filename, *args, **kwargs)

from_service_account_json = from_service_account_file

Expand Down
6 changes: 4 additions & 2 deletions tests/integration/goldens/asset/google/cloud/asset_v1/services/asset_service/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ def from_service_account_info(cls, info: dict, *args, **kwargs):
Returns:
AssetServiceAsyncClient: The constructed client.
"""
return AssetServiceClient.from_service_account_info.__func__(AssetServiceAsyncClient, info, *args, **kwargs) # type: ignore
sa_info_func = AssetServiceClient.from_service_account_info.__func__ # type: ignore
return sa_info_func(AssetServiceAsyncClient, info, *args, **kwargs)

@classmethod
def from_service_account_file(cls, filename: str, *args, **kwargs):
Expand All @@ -122,7 +123,8 @@ def from_service_account_file(cls, filename: str, *args, **kwargs):
Returns:
AssetServiceAsyncClient: The constructed client.
"""
return AssetServiceClient.from_service_account_file.__func__(AssetServiceAsyncClient, filename, *args, **kwargs) # type: ignore
sa_file_func = AssetServiceClient.from_service_account_file.__func__ # type: ignore
return sa_file_func(AssetServiceAsyncClient, filename, *args, **kwargs)

from_service_account_json = from_service_account_file

Expand Down
6 changes: 4 additions & 2 deletions ...on/goldens/credentials/google/iam/credentials_v1/services/iam_credentials/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ def from_service_account_info(cls, info: dict, *args, **kwargs):
Returns:
IAMCredentialsAsyncClient: The constructed client.
"""
return IAMCredentialsClient.from_service_account_info.__func__(IAMCredentialsAsyncClient, info, *args, **kwargs) # type: ignore
sa_info_func = IAMCredentialsClient.from_service_account_info.__func__ # type: ignore
return sa_info_func(IAMCredentialsAsyncClient, info, *args, **kwargs)

@classmethod
def from_service_account_file(cls, filename: str, *args, **kwargs):
Expand All @@ -113,7 +114,8 @@ def from_service_account_file(cls, filename: str, *args, **kwargs):
Returns:
IAMCredentialsAsyncClient: The constructed client.
"""
return IAMCredentialsClient.from_service_account_file.__func__(IAMCredentialsAsyncClient, filename, *args, **kwargs) # type: ignore
sa_file_func = IAMCredentialsClient.from_service_account_file.__func__ # type: ignore
return sa_file_func(IAMCredentialsAsyncClient, filename, *args, **kwargs)

from_service_account_json = from_service_account_file

Expand Down
6 changes: 4 additions & 2 deletions ...s/integration/goldens/eventarc/google/cloud/eventarc_v1/services/eventarc/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,8 @@ def from_service_account_info(cls, info: dict, *args, **kwargs):
Returns:
EventarcAsyncClient: The constructed client.
"""
return EventarcClient.from_service_account_info.__func__(EventarcAsyncClient, info, *args, **kwargs) # type: ignore
sa_info_func = EventarcClient.from_service_account_info.__func__ # type: ignore
return sa_info_func(EventarcAsyncClient, info, *args, **kwargs)

@classmethod
def from_service_account_file(cls, filename: str, *args, **kwargs):
Expand All @@ -140,7 +141,8 @@ def from_service_account_file(cls, filename: str, *args, **kwargs):
Returns:
EventarcAsyncClient: The constructed client.
"""
return EventarcClient.from_service_account_file.__func__(EventarcAsyncClient, filename, *args, **kwargs) # type: ignore
sa_file_func = EventarcClient.from_service_account_file.__func__ # type: ignore
return sa_file_func(EventarcAsyncClient, filename, *args, **kwargs)

from_service_account_json = from_service_account_file

Expand Down
6 changes: 4 additions & 2 deletions ...ration/goldens/logging/google/cloud/logging_v2/services/config_service_v2/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@ def from_service_account_info(cls, info: dict, *args, **kwargs):
Returns:
ConfigServiceV2AsyncClient: The constructed client.
"""
return ConfigServiceV2Client.from_service_account_info.__func__(ConfigServiceV2AsyncClient, info, *args, **kwargs) # type: ignore
sa_info_func = ConfigServiceV2Client.from_service_account_info.__func__ # type: ignore
return sa_info_func(ConfigServiceV2AsyncClient, info, *args, **kwargs)

@classmethod
def from_service_account_file(cls, filename: str, *args, **kwargs):
Expand All @@ -120,7 +121,8 @@ def from_service_account_file(cls, filename: str, *args, **kwargs):
Returns:
ConfigServiceV2AsyncClient: The constructed client.
"""
return ConfigServiceV2Client.from_service_account_file.__func__(ConfigServiceV2AsyncClient, filename, *args, **kwargs) # type: ignore
sa_file_func = ConfigServiceV2Client.from_service_account_file.__func__ # type: ignore
return sa_file_func(ConfigServiceV2AsyncClient, filename, *args, **kwargs)

from_service_account_json = from_service_account_file

Expand Down
6 changes: 4 additions & 2 deletions ...ation/goldens/logging/google/cloud/logging_v2/services/logging_service_v2/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,8 @@ def from_service_account_info(cls, info: dict, *args, **kwargs):
Returns:
LoggingServiceV2AsyncClient: The constructed client.
"""
return LoggingServiceV2Client.from_service_account_info.__func__(LoggingServiceV2AsyncClient, info, *args, **kwargs) # type: ignore
sa_info_func = LoggingServiceV2Client.from_service_account_info.__func__ # type: ignore
return sa_info_func(LoggingServiceV2AsyncClient, info, *args, **kwargs)

@classmethod
def from_service_account_file(cls, filename: str, *args, **kwargs):
Expand All @@ -105,7 +106,8 @@ def from_service_account_file(cls, filename: str, *args, **kwargs):
Returns:
LoggingServiceV2AsyncClient: The constructed client.
"""
return LoggingServiceV2Client.from_service_account_file.__func__(LoggingServiceV2AsyncClient, filename, *args, **kwargs) # type: ignore
sa_file_func = LoggingServiceV2Client.from_service_account_file.__func__ # type: ignore
return sa_file_func(LoggingServiceV2AsyncClient, filename, *args, **kwargs)

from_service_account_json = from_service_account_file

Expand Down
6 changes: 4 additions & 2 deletions ...ation/goldens/logging/google/cloud/logging_v2/services/metrics_service_v2/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ def from_service_account_info(cls, info: dict, *args, **kwargs):
Returns:
MetricsServiceV2AsyncClient: The constructed client.
"""
return MetricsServiceV2Client.from_service_account_info.__func__(MetricsServiceV2AsyncClient, info, *args, **kwargs) # type: ignore
sa_info_func = MetricsServiceV2Client.from_service_account_info.__func__ # type: ignore
return sa_info_func(MetricsServiceV2AsyncClient, info, *args, **kwargs)

@classmethod
def from_service_account_file(cls, filename: str, *args, **kwargs):
Expand All @@ -106,7 +107,8 @@ def from_service_account_file(cls, filename: str, *args, **kwargs):
Returns:
MetricsServiceV2AsyncClient: The constructed client.
"""
return MetricsServiceV2Client.from_service_account_file.__func__(MetricsServiceV2AsyncClient, filename, *args, **kwargs) # type: ignore
sa_file_func = MetricsServiceV2Client.from_service_account_file.__func__ # type: ignore
return sa_file_func(MetricsServiceV2AsyncClient, filename, *args, **kwargs)

from_service_account_json = from_service_account_file

Expand Down
6 changes: 4 additions & 2 deletions ...ldens/logging_internal/google/cloud/logging_v2/services/config_service_v2/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@ def from_service_account_info(cls, info: dict, *args, **kwargs):
Returns:
BaseConfigServiceV2AsyncClient: The constructed client.
"""
return BaseConfigServiceV2Client.from_service_account_info.__func__(BaseConfigServiceV2AsyncClient, info, *args, **kwargs) # type: ignore
sa_info_func = BaseConfigServiceV2Client.from_service_account_info.__func__ # type: ignore
return sa_info_func(BaseConfigServiceV2AsyncClient, info, *args, **kwargs)

@classmethod
def from_service_account_file(cls, filename: str, *args, **kwargs):
Expand All @@ -120,7 +121,8 @@ def from_service_account_file(cls, filename: str, *args, **kwargs):
Returns:
BaseConfigServiceV2AsyncClient: The constructed client.
"""
return BaseConfigServiceV2Client.from_service_account_file.__func__(BaseConfigServiceV2AsyncClient, filename, *args, **kwargs) # type: ignore
sa_file_func = BaseConfigServiceV2Client.from_service_account_file.__func__ # type: ignore
return sa_file_func(BaseConfigServiceV2AsyncClient, filename, *args, **kwargs)

from_service_account_json = from_service_account_file

Expand Down
6 changes: 4 additions & 2 deletions ...dens/logging_internal/google/cloud/logging_v2/services/logging_service_v2/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,8 @@ def from_service_account_info(cls, info: dict, *args, **kwargs):
Returns:
LoggingServiceV2AsyncClient: The constructed client.
"""
return LoggingServiceV2Client.from_service_account_info.__func__(LoggingServiceV2AsyncClient, info, *args, **kwargs) # type: ignore
sa_info_func = LoggingServiceV2Client.from_service_account_info.__func__ # type: ignore
return sa_info_func(LoggingServiceV2AsyncClient, info, *args, **kwargs)

@classmethod
def from_service_account_file(cls, filename: str, *args, **kwargs):
Expand All @@ -105,7 +106,8 @@ def from_service_account_file(cls, filename: str, *args, **kwargs):
Returns:
LoggingServiceV2AsyncClient: The constructed client.
"""
return LoggingServiceV2Client.from_service_account_file.__func__(LoggingServiceV2AsyncClient, filename, *args, **kwargs) # type: ignore
sa_file_func = LoggingServiceV2Client.from_service_account_file.__func__ # type: ignore
return sa_file_func(LoggingServiceV2AsyncClient, filename, *args, **kwargs)

from_service_account_json = from_service_account_file

Expand Down
6 changes: 4 additions & 2 deletions ...dens/logging_internal/google/cloud/logging_v2/services/metrics_service_v2/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ def from_service_account_info(cls, info: dict, *args, **kwargs):
Returns:
BaseMetricsServiceV2AsyncClient: The constructed client.
"""
return BaseMetricsServiceV2Client.from_service_account_info.__func__(BaseMetricsServiceV2AsyncClient, info, *args, **kwargs) # type: ignore
sa_info_func = BaseMetricsServiceV2Client.from_service_account_info.__func__ # type: ignore
return sa_info_func(BaseMetricsServiceV2AsyncClient, info, *args, **kwargs)

@classmethod
def from_service_account_file(cls, filename: str, *args, **kwargs):
Expand All @@ -106,7 +107,8 @@ def from_service_account_file(cls, filename: str, *args, **kwargs):
Returns:
BaseMetricsServiceV2AsyncClient: The constructed client.
"""
return BaseMetricsServiceV2Client.from_service_account_file.__func__(BaseMetricsServiceV2AsyncClient, filename, *args, **kwargs) # type: ignore
sa_file_func = BaseMetricsServiceV2Client.from_service_account_file.__func__ # type: ignore
return sa_file_func(BaseMetricsServiceV2AsyncClient, filename, *args, **kwargs)

from_service_account_json = from_service_account_file

Expand Down
6 changes: 4 additions & 2 deletions tests/integration/goldens/redis/google/cloud/redis_v1/services/cloud_redis/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,8 @@ def from_service_account_info(cls, info: dict, *args, **kwargs):
Returns:
CloudRedisAsyncClient: The constructed client.
"""
return CloudRedisClient.from_service_account_info.__func__(CloudRedisAsyncClient, info, *args, **kwargs) # type: ignore
sa_info_func = CloudRedisClient.from_service_account_info.__func__ # type: ignore
return sa_info_func(CloudRedisAsyncClient, info, *args, **kwargs)

@classmethod
def from_service_account_file(cls, filename: str, *args, **kwargs):
Expand All @@ -130,7 +131,8 @@ def from_service_account_file(cls, filename: str, *args, **kwargs):
Returns:
CloudRedisAsyncClient: The constructed client.
"""
return CloudRedisClient.from_service_account_file.__func__(CloudRedisAsyncClient, filename, *args, **kwargs) # type: ignore
sa_file_func = CloudRedisClient.from_service_account_file.__func__ # type: ignore
return sa_file_func(CloudRedisAsyncClient, filename, *args, **kwargs)

from_service_account_json = from_service_account_file

Expand Down
6 changes: 4 additions & 2 deletions ...ration/goldens/redis_selective/google/cloud/redis_v1/services/cloud_redis/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,8 @@ def from_service_account_info(cls, info: dict, *args, **kwargs):
Returns:
CloudRedisAsyncClient: The constructed client.
"""
return CloudRedisClient.from_service_account_info.__func__(CloudRedisAsyncClient, info, *args, **kwargs) # type: ignore
sa_info_func = CloudRedisClient.from_service_account_info.__func__ # type: ignore
return sa_info_func(CloudRedisAsyncClient, info, *args, **kwargs)

@classmethod
def from_service_account_file(cls, filename: str, *args, **kwargs):
Expand All @@ -130,7 +131,8 @@ def from_service_account_file(cls, filename: str, *args, **kwargs):
Returns:
CloudRedisAsyncClient: The constructed client.
"""
return CloudRedisClient.from_service_account_file.__func__(CloudRedisAsyncClient, filename, *args, **kwargs) # type: ignore
sa_file_func = CloudRedisClient.from_service_account_file.__func__ # type: ignore
return sa_file_func(CloudRedisAsyncClient, filename, *args, **kwargs)

from_service_account_json = from_service_account_file

Expand Down
Loading