Skip to content

Commit 33628a4

Browse files
sararobcopybara-github
authored andcommitted
chore: move CandidateResult, Event, Message, SessionInput and sub-fields to types/evals.py
PiperOrigin-RevId: 824538716
1 parent f51b813 commit 33628a4

File tree

11 files changed

+473
-438
lines changed

11 files changed

+473
-438
lines changed

tests/unit/vertexai/genai/replays/test_get_evaluation_run.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -251,10 +251,10 @@ def check_run_5133048044039700480_evaluation_item_results(
251251
assert universal_metric_result.explanation is None
252252
# Check the first rubric verdict.
253253
rubric_verdict_0 = universal_metric_result.rubric_verdicts[0]
254-
assert isinstance(rubric_verdict_0, types.RubricVerdict)
255-
assert rubric_verdict_0.evaluated_rubric == types.Rubric(
256-
content=types.RubricContent(
257-
property=types.RubricContentProperty(
254+
assert isinstance(rubric_verdict_0, types.evals.RubricVerdict)
255+
assert rubric_verdict_0.evaluated_rubric == types.evals.Rubric(
256+
content=types.evals.RubricContent(
257+
property=types.evals.RubricContentProperty(
258258
description="The response is in English."
259259
)
260260
),

tests/unit/vertexai/genai/replays/test_public_generate_rubrics.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ def test_public_method_generate_rubrics(client):
173173
assert "text_quality_rubrics" in first_rubric_group
174174
assert isinstance(first_rubric_group["text_quality_rubrics"], list)
175175
assert first_rubric_group["text_quality_rubrics"]
176-
assert isinstance(first_rubric_group["text_quality_rubrics"][0], types.Rubric)
176+
assert isinstance(first_rubric_group["text_quality_rubrics"][0], types.evals.Rubric)
177177

178178

179179
pytestmark = pytest_helper.setup(

tests/unit/vertexai/genai/test_evals.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2314,7 +2314,7 @@ def test_convert_with_intermediate_events_as_event_objects(self):
23142314
"response": ["Hi"],
23152315
"intermediate_events": [
23162316
[
2317-
vertexai_genai_types.Event(
2317+
vertexai_genai_types.evals.Event(
23182318
event_id="event1",
23192319
content=genai_types.Content(
23202320
parts=[genai_types.Part(text="intermediate event")]
@@ -2577,14 +2577,14 @@ def test_convert_with_conversation_history(self):
25772577
)
25782578

25792579
assert len(eval_case.conversation_history) == 2
2580-
assert eval_case.conversation_history[0] == vertexai_genai_types.Message(
2580+
assert eval_case.conversation_history[0] == vertexai_genai_types.evals.Message(
25812581
content=genai_types.Content(
25822582
parts=[genai_types.Part(text="Hello")], role="user"
25832583
),
25842584
turn_id="0",
25852585
author="user",
25862586
)
2587-
assert eval_case.conversation_history[1] == vertexai_genai_types.Message(
2587+
assert eval_case.conversation_history[1] == vertexai_genai_types.evals.Message(
25882588
content=genai_types.Content(
25892589
parts=[genai_types.Part(text="Hi")], role="system"
25902590
),
@@ -2786,7 +2786,7 @@ class TestEvent:
27862786
"""Unit tests for the Event class."""
27872787

27882788
def test_event_creation(self):
2789-
event = vertexai_genai_types.Event(
2789+
event = vertexai_genai_types.evals.Event(
27902790
event_id="event1",
27912791
content=genai_types.Content(
27922792
parts=[genai_types.Part(text="intermediate event")]
@@ -2820,7 +2820,7 @@ def test_eval_case_with_agent_eval_fields(self):
28202820
tool_declarations=[tool],
28212821
)
28222822
intermediate_events = [
2823-
vertexai_genai_types.Event(
2823+
vertexai_genai_types.evals.Event(
28242824
event_id="event1",
28252825
content=genai_types.Content(
28262826
parts=[genai_types.Part(text="intermediate event")]
@@ -2846,7 +2846,7 @@ class TestSessionInput:
28462846
"""Unit tests for the SessionInput class."""
28472847

28482848
def test_session_input_creation(self):
2849-
session_input = vertexai_genai_types.SessionInput(
2849+
session_input = vertexai_genai_types.evals.SessionInput(
28502850
user_id="user1",
28512851
state={"key": "value"},
28522852
)
@@ -3692,7 +3692,7 @@ def test_eval_case_to_agent_data(self):
36923692
tool_declarations=[tool],
36933693
)
36943694
intermediate_events = [
3695-
vertexai_genai_types.Event(
3695+
vertexai_genai_types.evals.Event(
36963696
event_id="event1",
36973697
content=genai_types.Content(
36983698
parts=[genai_types.Part(text="intermediate event")]
@@ -3722,7 +3722,7 @@ def test_eval_case_to_agent_data(self):
37223722

37233723
def test_eval_case_to_agent_data_events_only(self):
37243724
intermediate_events = [
3725-
vertexai_genai_types.Event(
3725+
vertexai_genai_types.evals.Event(
37263726
event_id="event1",
37273727
content=genai_types.Content(
37283728
parts=[genai_types.Part(text="intermediate event")]
@@ -3751,7 +3751,7 @@ def test_eval_case_to_agent_data_events_only(self):
37513751

37523752
def test_eval_case_to_agent_data_empty_event_content(self):
37533753
intermediate_events = [
3754-
vertexai_genai_types.Event(
3754+
vertexai_genai_types.evals.Event(
37553755
event_id="event1",
37563756
content=None,
37573757
)
@@ -3933,12 +3933,12 @@ def test_build_request_payload_various_field_types(self):
39333933
)
39343934
],
39353935
conversation_history=[
3936-
vertexai_genai_types.Message(
3936+
vertexai_genai_types.evals.Message(
39373937
content=genai_types.Content(
39383938
parts=[genai_types.Part(text="Turn 1 user")], role="user"
39393939
)
39403940
),
3941-
vertexai_genai_types.Message(
3941+
vertexai_genai_types.evals.Message(
39423942
content=genai_types.Content(
39433943
parts=[genai_types.Part(text="Turn 1 model")], role="model"
39443944
)

vertexai/_genai/_evals_common.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1271,16 +1271,19 @@ def _execute_agent_run_with_retry(
12711271
"""Executes agent run for a single prompt."""
12721272
try:
12731273
if isinstance(row["session_inputs"], str):
1274-
session_inputs = types.SessionInput.model_validate(
1274+
session_inputs = types.evals.SessionInput.model_validate(
12751275
json.loads(row["session_inputs"])
12761276
)
12771277
elif isinstance(row["session_inputs"], dict):
1278-
session_inputs = types.SessionInput.model_validate(row["session_inputs"])
1279-
elif isinstance(row["session_inputs"], types.SessionInput):
1278+
session_inputs = types.evals.SessionInput.model_validate(
1279+
row["session_inputs"]
1280+
)
1281+
elif isinstance(row["session_inputs"], types.evals.SessionInput):
12801282
session_inputs = row["session_inputs"]
12811283
else:
12821284
raise TypeError(
1283-
f"Unsupported session_inputs type: {type(row['session_inputs'])}. Expecting string or dict in types.SessionInput format."
1285+
f"Unsupported session_inputs type: {type(row['session_inputs'])}. "
1286+
"Expecting string or dict in types.evals.SessionInput format."
12841287
)
12851288
user_id = session_inputs.user_id
12861289
session_state = session_inputs.state

0 commit comments

Comments
 (0)