tests: Handle deprecation warnings in unit tests#862
Closed
Conversation
parthea
reviewed
Nov 12, 2025
| credentials_file="credentials.json", | ||
| credentials=mock.sentinel.credentials, | ||
| ) | ||
| with pytest.warns(DeprecationWarning): |
Collaborator
There was a problem hiding this comment.
Add a comment to clarify that credentials_file is deprecated. Applies throughout
noxfile.py
Outdated
Comment on lines
193
to
196
| # We use filterwarnings to ignore warnings that are out of our control, | ||
| # but we want to make sure that our own code does not generate warnings. | ||
| "-m", | ||
| "not filterwarnings", |
Collaborator
There was a problem hiding this comment.
We do want to see warnings as that may require code changes. We can filter warnings here with a comment that links to a bug with more information
python-api-core/pyproject.toml
Line 91 in 628003e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Deprecated
credentials_fileingoogle-auth:2. Future warnings are raised for Python
3.10:3.
.nox/unit_w_prerelease_deps-3-14failing: