fix as_select star logic

Author: TrevorBergeron

bigframes/core/compile/sqlglot/sqlglot_ir.py

@@ -507,11 +507,7 @@ def _as_select(self) -> sge.Select:
         if isinstance(self.expr, sge.Select):
             return self.expr
         else:  # table or cte
-            return (
-                sge.Select()
-                .select(sge.Column(this=sge.Star(), table=self.expr))
-                .from_(self.expr)
-            )
+            return sge.Select().select(sge.Star()).from_(self.expr)
 
     def _as_subquery(self) -> sge.Subquery:
         return self._as_select().subquery()

tests/unit/core/compile/sqlglot/snapshots/test_compile_concat/test_compile_concat/out.sql

@@ -14,7 +14,7 @@ WITH `bfcte_0` AS (
   FROM `bigframes-dev`.`sqlglot_test`.`scalar_types` AS `bft_0`
 ), `bfcte_2` AS (
   SELECT
-    `bfcte_0`.*
+    *
   FROM `bfcte_0`
 )
 SELECT

tests/unit/core/compile/sqlglot/snapshots/test_compile_concat/test_compile_concat_filter_sorted/out.sql

@@ -24,11 +24,11 @@ WITH `bfcte_0` AS (
     `bool_col`
 ), `bfcte_4` AS (
   SELECT
-    `bfcte_0`.*
+    *
   FROM `bfcte_0`
 ), `bfcte_5` AS (
   SELECT
-    `bfcte_2`.*
+    *
   FROM `bfcte_2`
 )
 SELECT

tests/unit/core/compile/sqlglot/snapshots/test_compile_fromrange/test_compile_fromrange/out.sql

@@ -32,7 +32,7 @@ WITH `bfcte_0` AS (
   )
 ), `bfcte_4` AS (
   SELECT
-    `bfcte_0`.*
+    *
   FROM `bfcte_0`
 ), `bfcte_5` AS (
   SELECT
@@ -44,7 +44,7 @@ WITH `bfcte_0` AS (
   )
 ), `bfcte_6` AS (
   SELECT
-    `bfcte_2`.*
+    *
   FROM `bfcte_2`
 )
 SELECT

tests/unit/core/compile/sqlglot/snapshots/test_compile_join/test_compile_join_w_on/bool_col/out.sql

@@ -10,7 +10,7 @@ WITH `bfcte_0` AS (
   FROM `bigframes-dev`.`sqlglot_test`.`scalar_types` AS `bft_0`
 ), `bfcte_2` AS (
   SELECT
-    `bfcte_0`.*
+    *
   FROM `bfcte_0`
 )
 SELECT

tests/unit/core/compile/sqlglot/snapshots/test_compile_join/test_compile_join_w_on/float64_col/out.sql

@@ -10,7 +10,7 @@ WITH `bfcte_0` AS (
   FROM `bigframes-dev`.`sqlglot_test`.`scalar_types` AS `bft_0`
 ), `bfcte_2` AS (
   SELECT
-    `bfcte_0`.*
+    *
   FROM `bfcte_0`
 )
 SELECT

tests/unit/core/compile/sqlglot/snapshots/test_compile_join/test_compile_join_w_on/int64_col/out.sql

@@ -10,7 +10,7 @@ WITH `bfcte_0` AS (
   FROM `bigframes-dev`.`sqlglot_test`.`scalar_types` AS `bft_0`
 ), `bfcte_2` AS (
   SELECT
-    `bfcte_0`.*
+    *
   FROM `bfcte_0`
 )
 SELECT

tests/unit/core/compile/sqlglot/snapshots/test_compile_join/test_compile_join_w_on/numeric_col/out.sql

@@ -10,7 +10,7 @@ WITH `bfcte_0` AS (
   FROM `bigframes-dev`.`sqlglot_test`.`scalar_types` AS `bft_0`
 ), `bfcte_2` AS (
   SELECT
-    `bfcte_0`.*
+    *
   FROM `bfcte_0`
 )
 SELECT

tests/unit/core/compile/sqlglot/snapshots/test_compile_join/test_compile_join_w_on/string_col/out.sql

@@ -10,11 +10,11 @@ WITH `bfcte_0` AS (
   FROM `bigframes-dev`.`sqlglot_test`.`scalar_types` AS `bft_0`
 ), `bfcte_2` AS (
   SELECT
-    `bfcte_0`.*
+    *
   FROM `bfcte_0`
 ), `bfcte_3` AS (
   SELECT
-    `bfcte_1`.*
+    *
   FROM `bfcte_1`
 )
 SELECT

tests/unit/core/compile/sqlglot/snapshots/test_compile_join/test_compile_join_w_on/time_col/out.sql

@@ -10,11 +10,11 @@ WITH `bfcte_0` AS (
   FROM `bigframes-dev`.`sqlglot_test`.`scalar_types` AS `bft_0`
 ), `bfcte_2` AS (
   SELECT
-    `bfcte_0`.*
+    *
   FROM `bfcte_0`
 ), `bfcte_3` AS (
   SELECT
-    `bfcte_1`.*
+    *
   FROM `bfcte_1`
 )
 SELECT