Skip to content

Commit a474560

Browse files
committed
removed metrics superclass from interceptor
1 parent 6a4d742 commit a474560

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

google/cloud/bigtable/data/_async/metrics_interceptor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ async def _get_metadata(source) -> dict[str, str | bytes] | None:
9090

9191
@CrossSync.convert_class(sync_name="BigtableMetricsInterceptor")
9292
class AsyncBigtableMetricsInterceptor(
93-
UnaryUnaryClientInterceptor, UnaryStreamClientInterceptor, MetricsHandler
93+
UnaryUnaryClientInterceptor, UnaryStreamClientInterceptor
9494
):
9595
"""
9696
An async gRPC interceptor to add client metadata and print server metadata.

google/cloud/bigtable/data/_sync_autogen/metrics_interceptor.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
from google.cloud.bigtable.data._metrics.data_model import ActiveOperationMetric
2222
from google.cloud.bigtable.data._metrics.data_model import OperationState
2323
from google.cloud.bigtable.data._metrics.data_model import OperationType
24-
from google.cloud.bigtable.data._metrics.handlers._base import MetricsHandler
2524
from grpc import UnaryUnaryClientInterceptor
2625
from grpc import UnaryStreamClientInterceptor
2726

@@ -57,7 +56,7 @@ def _get_metadata(source) -> dict[str, str | bytes] | None:
5756

5857

5958
class BigtableMetricsInterceptor(
60-
UnaryUnaryClientInterceptor, UnaryStreamClientInterceptor, MetricsHandler
59+
UnaryUnaryClientInterceptor, UnaryStreamClientInterceptor
6160
):
6261
"""
6362
An async gRPC interceptor to add client metadata and print server metadata.

tests/unit/data/_sync_autogen/test_client.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1462,8 +1462,7 @@ def test_read_rows_timeout(self, operation_timeout):
14621462
)
14631463

14641464
@pytest.mark.parametrize(
1465-
"per_request_t, operation_t, expected_num",
1466-
[(0.05, 0.08, 2), (0.05, 0.14, 3), (0.05, 0.24, 5)],
1465+
"per_request_t, operation_t, expected_num", [(0.1, 0.19, 2), (0.1, 0.29, 3)]
14671466
)
14681467
def test_read_rows_attempt_timeout(self, per_request_t, operation_t, expected_num):
14691468
"""Ensures that the attempt_timeout is respected and that the number of

0 commit comments

Comments
 (0)