Skip to content

Commit f5d3152

Browse files
authored
chore: Rerouted legacy client row filters to data client row filters. (#1255)
**Changes made:** - Used import aliasing to remove most of the legacy client row filter code and use the data client row filter code in its place. - Some of the data client row filter classes had to be slightly modified for backwards compatibility with the legacy client row filter classes' interface. - As part of this move, `to_pb` has been replaced with `_to_pb`, and I have adjusted references to `<RowFilter>.to_pb` in the libraries and unit tests. This is for eventually shimming up `CheckAndMutateRows`, and other row mutation operations as well.
1 parent 914006d commit f5d3152

File tree

7 files changed

+187
-821
lines changed

7 files changed

+187
-821
lines changed

google/cloud/bigtable/row.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ def _delete_cells(self, column_family_id, columns, time_range=None, state=None):
230230
else:
231231
delete_kwargs = {}
232232
if time_range is not None:
233-
delete_kwargs["time_range"] = time_range.to_pb()
233+
delete_kwargs["time_range"] = time_range._to_pb()
234234

235235
to_append = []
236236
for column in columns:
@@ -601,7 +601,7 @@ def commit(self):
601601
resp = data_client.check_and_mutate_row(
602602
table_name=self._table.name,
603603
row_key=self._row_key,
604-
predicate_filter=self._filter.to_pb(),
604+
predicate_filter=self._filter._to_pb(),
605605
app_profile_id=self._table._app_profile_id,
606606
true_mutations=true_mutations,
607607
false_mutations=false_mutations,

0 commit comments

Comments
 (0)