fix system test

Author: Linchin

google/cloud/firestore_v1/base_pipeline.py

@@ -275,12 +275,12 @@ def find_nearest(
 
     def literals(
         self,
-        documents: Selectable,
+        *documents: Selectable,
     ) -> "_BasePipeline":
         """
         TODO: add docstring.
         """
-        return self._append(stages.Literals(documents))
+        return self._append(stages.Literals(*documents))
 
     def replace_with(
         self,

google/cloud/firestore_v1/pipeline_stages.py

@@ -345,12 +345,18 @@ def _pb_args(self):
 class Literals(Stage):
     """TODO: add docstring."""
 
-    def __init__(self, documents: Selectable):
+    def __init__(self, *documents: Selectable):
         super().__init__("literals")
-        self.documents = Field(documents) if isinstance(documents, str) else documents
+        self.documents = documents
 
     def _pb_args(self):
-        return [self.documents._to_pb()]
+        args = []
+        for doc in self.documents:
+            if hasattr(doc, "_to_pb"):
+                args.append(doc._to_pb())
+            else:
+                args.append(encode_value(doc))
+        return args
 
 
 class Offset(Stage):

tests/system/pipeline_e2e/general.yaml

@@ -688,23 +688,20 @@ tests:
   - description: literals
     pipeline:
       - Literals:
-        - Constant:
-            - title: "The Hitchhiker's Guide to the Galaxy"
-              author: "Douglas Adams"
+        - title: "The Hitchhiker's Guide to the Galaxy"
+          author: "Douglas Adams"
     assert_results:
       - title: "The Hitchhiker's Guide to the Galaxy"
         author: "Douglas Adams"
     assert_proto:
       pipeline:
         stages:
         - args:
-          - arrayValue:
-              values:
-              - mapValue:
-                  fields:
-                    author:
-                      stringValue: "Douglas Adams"
-                    title:
-                      stringValue: "The Hitchhiker's Guide to the Galaxy"
+          - mapValue:
+              fields:
+                author:
+                  stringValue: "Douglas Adams"
+                title:
+                  stringValue: "The Hitchhiker's Guide to the Galaxy"
           name: literals
 

tests/unit/v1/test_pipeline_stages.py

@@ -521,24 +521,27 @@ def _make_one(self, *args, **kwargs):
         return stages.Literals(*args, **kwargs)
 
     def test_ctor(self):
-        val = Constant.of({"a": 1})
-        instance = self._make_one(val)
-        assert instance.documents == val
+        val1 = Constant.of({"a": 1})
+        val2 = Constant.of({"b": 2})
+        instance = self._make_one(val1, val2)
+        assert instance.documents == (val1, val2)
         assert instance.name == "literals"
 
     def test_repr(self):
-        val = Constant.of({"a": 1})
-        instance = self._make_one(val)
+        val1 = Constant.of({"a": 1})
+        instance = self._make_one(val1)
         repr_str = repr(instance)
-        assert repr_str == "Literals(documents=Constant.of({'a': 1}))"
+        assert repr_str == "Literals(documents=(Constant.of({'a': 1}),))"
 
     def test_to_pb(self):
-        val = Constant.of({"a": 1})
-        instance = self._make_one(val)
+        val1 = Constant.of({"a": 1})
+        val2 = Constant.of({"b": 2})
+        instance = self._make_one(val1, val2)
         result = instance._to_pb()
         assert result.name == "literals"
-        assert len(result.args) == 1
+        assert len(result.args) == 2
         assert result.args[0].map_value.fields["a"].integer_value == 1
+        assert result.args[1].map_value.fields["b"].integer_value == 2
         assert len(result.options) == 0