User Error when Found Reports is empty

[EjPlatzer]

The FoundReports component displays an error snackbar to the user when the API returns a 404 not found response, which is confusing behavior for users.

After the restart, going to 360train.gordon.edu gives me an error message popup: "Error fetching found reports"

Originally posted by @russtuck in #1190 (comment)

[Centerville1]

The FoundReports component displays an error snackbar to the user when the API returns a 404 not found response, which is confusing behavior for users.

After the restart, going to 360train.gordon.edu gives me an error message popup: "Error fetching found reports"

Originally posted by @russtuck in #1190 (comment)

@EjPlatzer is this an ongoing issue? I was making some database changes to prod for our release, which temporarily broke our API routes, hence the 404 for that component specifically... Normally you shouldn't get a 404 unless there're much bigger issues with the API I believe?

Everything should be working again now, as far as I can tell

[EjPlatzer]

...

@EjPlatzer is this an ongoing issue? I was making some database changes to prod for our release, which temporarily broke our API routes, hence the 404 for that component specifically... Normally you shouldn't get a 404 unless there're much bigger issues with the API I believe?

Everything should be working again now, as far as I can tell

Actually, you seem to have made a practice of returning NotFound() from API routes when the data is empty, which translates to HTTP 404 Not Found Error over the wire. I generally recommend against that practice (I prefer to just return either [] or null) for exactly this reason, because empty data is not really an exception. However, a lot of the API is already coded in this way.

You can see this, for example, in LostAndFoundController.GetMissingItems.