From 2b14ea0e8340e1a490462513d2576a5338fde7f8 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Thu, 22 Aug 2024 13:00:40 +0200 Subject: [PATCH 1/3] go.mod: github.com/google/go-cmp v0.6.0 Update the minimum required version; this removes the purego fallbacks. full diff: https://github.com/google/go-cmp/compare/v0.5.9...v0.6.0 Signed-off-by: Sebastiaan van Stijn --- go.mod | 2 +- go.sum | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/go.mod b/go.mod index b78b50e..fb5009e 100644 --- a/go.mod +++ b/go.mod @@ -3,7 +3,7 @@ module gotest.tools/v3 go 1.17 require ( - github.com/google/go-cmp v0.5.9 + github.com/google/go-cmp v0.6.0 golang.org/x/tools v0.13.0 ) diff --git a/go.sum b/go.sum index 3aab130..a47bd92 100644 --- a/go.sum +++ b/go.sum @@ -1,5 +1,5 @@ -github.com/google/go-cmp v0.5.9 h1:O2Tfq5qg4qc4AmwVlvv0oLiVAGB7enBSJ2x2DqQFi38= -github.com/google/go-cmp v0.5.9/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY= +github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI= +github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY= github.com/yuin/goldmark v1.4.13/go.mod h1:6yULJ656Px+3vBD8DxQVa3kxgyrAnzto9xy5taEt/CY= golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w= golang.org/x/crypto v0.0.0-20210921155107-089bfa567519/go.mod h1:GvvjBRRGRdwPK5ydBHafDWAxML/pGHZbMvKqRZ5+Abc= From 78a8cbc90273970de9a8f7c4418eb58f07c7e0d0 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Thu, 22 Aug 2024 13:24:46 +0200 Subject: [PATCH 2/3] try installing go1.20 on Windows The TestFromDirSymlink test is failing on Windows; === Failed === FAIL: fs TestFromDirSymlink (0.01s) ops_test.go:55: assertion failed: directory C:\Users\circleci\AppData\Local\Temp\test-from-dir-992742947 does not match expected: \a\b\3 target: expected C:\some\inexistent\link got \some\inexistent\link Unlike Linux, Windows is always testing against "latest" version of Golang; Chocolatey v2.2.2 Upgrading the following packages: golang By upgrading, you accept licenses for the packages. You have golang v1.22.2 installed. Version 1.23.0 is available based on your source(s). Progress: Downloading golang 1.23.0... 100% Try installing go1.20 to see if that's related Signed-off-by: Sebastiaan van Stijn --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 91fea21..21325bb 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -43,7 +43,7 @@ workflows: git config --global core.autocrlf false git config --global core.symlinks true - run: | - choco upgrade golang + choco install golang --allow-downgrade --version=1.20 echo 'export PATH="$PATH:/c/Program Files/Go/bin"' > $BASH_ENV - run: go version - run: go install gotest.tools/gotestsum@latest From 617d96a52e14c2a51af58c09ef16fbad41d80753 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Thu, 22 Aug 2024 15:33:02 +0200 Subject: [PATCH 3/3] run tests on go1.22 trying to find what dependency / versions are needed to prevent a panic Signed-off-by: Sebastiaan van Stijn --- .circleci/config.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 21325bb..5d7314e 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -43,7 +43,6 @@ workflows: git config --global core.autocrlf false git config --global core.symlinks true - run: | - choco install golang --allow-downgrade --version=1.20 echo 'export PATH="$PATH:/c/Program Files/Go/bin"' > $BASH_ENV - run: go version - run: go install gotest.tools/gotestsum@latest