-
Notifications
You must be signed in to change notification settings - Fork 0
fix: check line table bounds #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1181d9b to
99c9866
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
src/stack_trace.rs:252
- [nitpick] Consider providing additional context in the error message (for example, including the value of 'lasti') so that debugging failures in line number lookup becomes easier.
.or_else(|err| bail!("Failed to get line number {err:?}"))
src/line_numbers.rs:4
- [nitpick] Consider implementing Display and std::error::Error for the Error type to supply more useful information when errors occur.
pub struct Error;
|
added a fuzzer, imediately found more problems |
c7f3dc0 to
ba5d000
Compare
fd623fa to
7ec9e14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- fuzz/.gitignore: Language not supported
096cd9a to
144fb10
Compare
- fix oob read panic - fix int overflow in debug mode - add fuzzer - lintt - fix upload artifacts names - maybe fix CI
25013e0 to
afe34a3
Compare
kolesnikovae
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Inspirations:
benfred#755
benfred#736