-
Notifications
You must be signed in to change notification settings - Fork 848
Open
Description
Actual
Currently the extensions component defined in:
Lines 32 to 33 in 58689e0
| // Extension is an interface for extensions in graphql | |
| type Extension interface { |
Contains methods that are named in a way that could be clearer, for example:
Lines 40 to 41 in 58689e0
| // ParseDidStart is being called before starting the parse | |
| ParseDidStart(context.Context) (context.Context, ParseFinishFunc) |
^ It is not clear if the hook executes before or after the Parse process started.
Expected
We want to update the Extensions interface methods to a clearer naming using precise prefix, eg:
ParseDidStart -> BeforeParseHook
Using the same re-naming strategy: Before/After<Component Name>Hook we want to update the other methods.
For backwards compatibility let's keep the existing methods as a fallback.
Notes
- This naming improvement was found while working in a University Thesis via the following PR: Add Extensions component implementation description chris-ramon/thesis-graphql-go#66
Metadata
Metadata
Assignees
Labels
No labels