Skip to content

Commit 1cb3f44

Browse files
committed
code review
1 parent 2cb3021 commit 1cb3f44

File tree

2 files changed

+5
-28
lines changed

2 files changed

+5
-28
lines changed

src/components/info-card/index.tsx

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -17,18 +17,7 @@ export interface InfoCardImageRow {
1717
alt?: string
1818
}
1919

20-
export interface InfoCardSplitRow {
21-
type: "split"
22-
23-
left: ReactNode
24-
right: ReactNode
25-
}
26-
27-
export type InfoCardRow =
28-
| InfoCardLabelRow
29-
| InfoCardTitleRow
30-
| InfoCardImageRow
31-
| InfoCardSplitRow
20+
export type InfoCardRow = InfoCardLabelRow | InfoCardTitleRow | InfoCardImageRow
3221

3322
export interface InfoCardProps {
3423
rows: InfoCardRow[]
@@ -62,18 +51,6 @@ export function InfoCardRow({ row }: { row: InfoCardRow }) {
6251
</div>
6352
)
6453
}
65-
case "split": {
66-
return (
67-
<div className="flex grid grid-cols-2 flex-wrap divide-x divide-neu-200 border-t border-neu-200 text-neu-700 dark:divide-neu-100 dark:border-neu-100">
68-
<div className="flex items-center gap-1.5 px-4 py-2.5 text-neu-700 dark:text-neu-600">
69-
{row.left}
70-
</div>
71-
<div className="typography-body-sm flex flex-wrap items-center gap-2 px-4 py-2.5 text-neu-700 dark:text-neu-600">
72-
{row.right}
73-
</div>
74-
</div>
75-
)
76-
}
7754
}
7855
}
7956

src/pages/community/ambassadors/data.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,12 +92,12 @@ export const ambassadors: Ambassador[] = [
9292
tags: [
9393
{
9494
label: "GitHub",
95-
url: "https://github.com/aexol/",
95+
url: "https://github.com/eddeee888",
9696
icon: <GitHubIcon className="h-5 w-5" />,
9797
},
9898
{
9999
label: "LinkedIn",
100-
url: "https://www.linkedin.com/in/arturczemiel/",
100+
url: "https://www.linkedin.com/in/eddeee888/",
101101
icon: <LinkedInIcon className="h-5 w-5" />,
102102
},
103103
{
@@ -143,7 +143,7 @@ export const ambassadors: Ambassador[] = [
143143
},
144144
{
145145
label: "LinkedIn",
146-
url: "https://www.linkedin.com/in/erikwrede",
146+
url: "https://www.linkedin.com/in/itamarkestenbaum/",
147147
icon: <LinkedInIcon className="h-5 w-5" />,
148148
},
149149
{
@@ -380,7 +380,7 @@ export const ambassadors: Ambassador[] = [
380380
},
381381
{
382382
label: "X",
383-
url: "http://twitter.com/_philpl",
383+
url: "http://x.com/_philpl",
384384
icon: <TwitterIcon className="h-5 w-5" />,
385385
},
386386
{

0 commit comments

Comments
 (0)