Skip to content

fix: Update batch tools and add collection tool registration#42

Merged
jayscambler merged 1 commit intomainfrom
jay/cfos-27-mcp-server-components
Jun 19, 2025
Merged

fix: Update batch tools and add collection tool registration#42
jayscambler merged 1 commit intomainfrom
jay/cfos-27-mcp-server-components

Conversation

@jayscambler
Copy link
Contributor

Summary

This PR contains follow-up fixes after the MCP implementation merge:

  1. Fix FrameRecord initialization in batch tools

    • Removed invalid parameters: , ,
    • These fields don't exist in the FrameRecord constructor
  2. Add collection tools registration to ToolRegistry

    • Ensures collection tools are properly registered when transport is available
    • Was missing from the initial implementation
  3. Add implementation documentation

    • Added documentation for collection metadata storage approach
    • Includes analysis of Lance filtering limitations

Testing

All existing tests continue to pass.

- Fix FrameRecord initialization in batch tools (remove invalid parameters)
- Add collection tools registration to ToolRegistry
- Add implementation documentation for collection metadata fixes
@linear
Copy link

linear bot commented Jun 19, 2025

@jayscambler jayscambler merged commit ae4ecc7 into main Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant