-
Notifications
You must be signed in to change notification settings - Fork 4.6k
pickfirst: Remove old pickfirst #8672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8672 +/- ##
==========================================
+ Coverage 83.03% 83.15% +0.11%
==========================================
Files 417 417
Lines 32310 32182 -128
==========================================
- Hits 26829 26761 -68
+ Misses 4087 4038 -49
+ Partials 1394 1383 -11
🚀 New features to boost your workflow:
|
| // | ||
| // Notice: This package is EXPERIMENTAL and may be changed or removed in a | ||
| // later release. | ||
| package pickfirstleaf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecate the whole package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Since this PR is removing a test workflow, it will higher extra privileges to merge.
Fixes: #8561
Addresses: #6472
The new pickfirst has been the default since gRPC Go v1.71.0 and all reported bugs have been fixed. This PR removes the old pickfirst policy completely.
The exported symbols in the
pickfirstleafpackage are retained with a deprecation notice for removal after one release.RELEASE NOTES:
pick_firstLB policy. The newpick_firsthas been the default since v 1.71.0.