Skip to content

Conversation

@arjan-bal
Copy link
Contributor

@arjan-bal arjan-bal commented Oct 27, 2025

Fixes: #8561
Addresses: #6472

The new pickfirst has been the default since gRPC Go v1.71.0 and all reported bugs have been fixed. This PR removes the old pickfirst policy completely.

The exported symbols in the pickfirstleaf package are retained with a deprecation notice for removal after one release.

RELEASE NOTES:

  • pickfirst: Remove the old pick_first LB policy. The new pick_first has been the default since v 1.71.0.

@arjan-bal arjan-bal added this to the 1.77 Release milestone Oct 27, 2025
@arjan-bal arjan-bal added Type: Behavior Change Behavior changes not categorized as bugs Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. labels Oct 27, 2025
@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

❌ Patch coverage is 91.06145% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.15%. Comparing base (0b57abb) to head (0b30392).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
balancer/pickfirst/pickfirst.go 91.11% 20 Missing and 11 partials ⚠️
balancer/pickfirst/pickfirstleaf/pickfirstleaf.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8672      +/-   ##
==========================================
+ Coverage   83.03%   83.15%   +0.11%     
==========================================
  Files         417      417              
  Lines       32310    32182     -128     
==========================================
- Hits        26829    26761      -68     
+ Misses       4087     4038      -49     
+ Partials     1394     1383      -11     
Files with missing lines Coverage Δ
balancer/leastrequest/leastrequest.go 88.65% <100.00%> (ø)
balancer/ringhash/ringhash.go 94.11% <100.00%> (ø)
balancer/roundrobin/roundrobin.go 100.00% <100.00%> (ø)
balancer/weightedroundrobin/balancer.go 86.31% <100.00%> (+0.76%) ⬆️
internal/envconfig/envconfig.go 100.00% <ø> (ø)
xds/googledirectpath/googlec2p.go 88.88% <ø> (+1.83%) ⬆️
balancer/pickfirst/pickfirstleaf/pickfirstleaf.go 0.00% <0.00%> (-89.68%) ⬇️
balancer/pickfirst/pickfirst.go 89.62% <91.11%> (+50.91%) ⬆️

... and 19 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

//
// Notice: This package is EXPERIMENTAL and may be changed or removed in a
// later release.
package pickfirstleaf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecate the whole package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Since this PR is removing a test workflow, it will higher extra privileges to merge.

@easwars
Copy link
Contributor

easwars commented Oct 28, 2025

I'm skipping reviewing this as it has already been approved by @dfawley.

Also, moving it back to @dfawley for the merge as it requires higher privileges to merge because of the removal of a test workflow.

@easwars easwars assigned dfawley and unassigned easwars Oct 28, 2025
@easwars easwars removed their request for review October 28, 2025 06:31
@arjan-bal arjan-bal merged commit e3e142d into grpc:master Oct 28, 2025
22 of 23 checks passed
@arjan-bal arjan-bal deleted the remove-old-pickfirst branch October 28, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. Type: Behavior Change Behavior changes not categorized as bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup in google-c2p resolver after removing GRPC_EXPERIMENTAL_ENABLE_NEW_PICK_FIRST

3 participants