Skip to content

Commit 4cd20f7

Browse files
authored
[Announcements] Improve announcement explanations (#11946)
## Summary of the problem <!-- Why are these changes being made? What problem does it solve? Link any related issues to provide more details. --> There was some confusion about monthly announcements when the canceled emails got sent out a couple days ago. ## Describe your changes <!-- Explain your thought process to the solution and provide a quick summary of the changes. --> Adds the announcement explanation partial to the canceled email and adds a link to the new monthly announcement blog post in the explanation partial. This PR should not be merged until hackclub/hcb-engr#108 is merged and deployed.
1 parent 19aaef0 commit 4cd20f7

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<p>
22
Announcements are a feature where you can send out updates to users following your organization.
33
You are receiving this message because you have auto-scheduled monthly announcements enabled in your organization settings.
4+
For more information on monthly announcements, check out <%= link_to "our blog post", "https://blog.hcb.hackclub.com/posts/monthly-announcements" %>!
45
</p>

app/views/announcement_mailer/canceled.html.erb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,15 @@
66

77
<p>
88
Your monthly announcement that was scheduled to send on <%= scheduled_for_string %>
9-
has been canceled since blocks contained in this announcement have no data.
9+
has been canceled since there is no recent activity to show in this announcement.
1010
</p>
1111

1212
<p>
1313
If you would like, you can keep this monthly announcement to be sent on <%= scheduled_for_string %> by <%= link_to "editing it on HCB", edit_announcement_url(@announcement) %>.
1414
</p>
1515

16+
<%= render "announcement_mailer/explanation" %>
17+
1618
<p>
1719
Sincerely,
1820
<br><br>

0 commit comments

Comments
 (0)