[Governance ApprovalAttempt] Handle redundant approvals #11953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of erroring when an admin attempts to approve a second time, we record the redundant approval. See `one_successful_approval_per_transfer` validation for explanation on why redundant approvals happen.
Member
Author
|
Merging in the interest of unblocking the ops team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the problem
At the moment, when the admin attempts to approve a transfer a second time, it errors on them, blocking the transfer from being processed.
See
one_successful_approval_per_transfervalidation for explanation on why redundant approvals happen.Describe your changes
Instead of erroring when an admin attempts to approve a second time, we record the redundant approval.