V0.3.5 & Support tuple all

Author: hakancelikdev

action.yml

@@ -12,7 +12,7 @@ inputs:
 runs:
   using: "composite"
   steps:
-    - run: pip install --upgrade pip && python -m pip install pyall==0.3.4
+    - run: pip install --upgrade pip && python -m pip install pyall==0.3.5
       shell: bash
     - run: pyall  ${{ inputs.extra_args }}
       shell: bash

docs/changelog.md

@@ -7,31 +7,20 @@ this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 
 ## [Unreleased]
 
-## [0.3.4] - 2022-10-28
-
-- Version fix
-
-## [0.3.3] - 2022-10-28
-
-### Added
-
-- Python 3.11 support
-- Github Action
-
-### Changed
-
-- Single quotes to double quotes when refactoring
-
-## [0.3.1] - 2022-07-17
+## [0.3.5] - 2022-10-28
 
 ### Added
 
+- Support Python3.11
 - Support Python3.10
 - Add py.typed
+- Github Action
 
 ### Changed
 
+- Single quotes to double quotes when refactoring
 - Apply src layout
+- Support tuple all
 
 ## [0.2.0] - 2021-04-11
 

src/pyall/__init__.py

@@ -1,6 +1,6 @@
 __all__ = ("__version__", "__description__")
 
-__version__ = "0.3.4"
-__description__ = (
+__version__ = "0.3.5"  # pyall: public
+__description__ = (  # pyall: public
     "Pyall is a linter that tries to keep the __all __ in your Python modules always up to date."  # noqa: E501
 )

src/pyall/analyzer.py

@@ -37,7 +37,7 @@ def visit_Name(self, node: ast.Name) -> None:
 
     @Rule.apply
     def visit_Assign(self, node: ast.Assign) -> None:
-        assert isinstance(node.value, ast.List)
+        assert isinstance(node.value, (ast.List, ast.Tuple))
         for item in node.value.elts:
             if isinstance(item, ast.Constant):
                 self.actual_all.add(str(item.value))
@@ -85,6 +85,7 @@ def set_extra_attr(self, tree: ast.AST) -> None:
             if re.search(C.ADD_COMMENTS_REGEX_PATTERN, line, re.IGNORECASE):
                 lineno = start[0]
                 add.add(lineno)
+
         for node in ast.walk(tree):
             if isinstance(node, C.ALL_NODE) and node.lineno in skip:
                 node.skip = True  # type: ignore

src/pyall/rule.py

@@ -106,6 +106,8 @@ def _rule_def_name(node) -> bool:
 
 @Rule.register((ast.Name,))  # type: ignore
 def _rule_name_name(node) -> bool:
+    if hasattr(node, "add"):
+        return node.add is True
     return (node.id.isupper() or node.id[0].isupper()) and not node.id.startswith("_")
 
 

tests/test_refactor.py

@@ -43,29 +43,41 @@ def _is_equal_source_to_refactor(action: str, expected: str) -> bool:
                 _key = "_value"
                 Key = "Value"
                 KEY = "VALUE"
-            """,
+        """,
         """\
                 __all__ = ["KEY", "Key"]
 
                 key = "value"
                 _key = "_value"
                 Key = "Value"
                 KEY = "VALUE"
-            """,
+        """,
     ),
     (
         """\
                 import x
 
                 def func():...
-            """,
+        """,
         """\
                 import x
 
                 __all__ = ["func"]
 
                 def func():...
-            """,
+        """,
+    ),
+    (
+        """\
+                __all__ = ("var",)
+                
+                var = 1
+        """,
+        """\
+                __all__ = ("var",)
+                
+                var = 1
+        """,
     ),
     (
         """\
@@ -142,6 +154,30 @@ def x():...
 
         """,
     ),
+    (
+        """\
+            __all__ = ["x"]
+
+            x = 1  # pyall: public
+        """,
+        """\
+            __all__ = ["x"]
+
+            x = 1  # pyall: public
+        """,
+    ),
+    (
+        """\
+            __all__ = []
+
+            XXX = 1  # pyall: not-public
+        """,
+        """\
+            __all__ = []
+
+            XXX = 1  # pyall: not-public
+        """,
+    ),
 ]