From ada916902c129c24926c8bb93d041eacb6e71434 Mon Sep 17 00:00:00 2001 From: "p.ivanov" Date: Wed, 9 Aug 2017 15:51:26 +0300 Subject: [PATCH 1/2] fixes bug with unneccessary throttledResize call when window width not changes --- js/angular-sticky.js | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/js/angular-sticky.js b/js/angular-sticky.js index 582ca45..6ff0ade 100755 --- a/js/angular-sticky.js +++ b/js/angular-sticky.js @@ -460,6 +460,7 @@ angular.module('hl.sticky', []) $get: function($rootScope, $window, $document, $log, DefaultStickyStackName, hlStickyElement, hlStickyStack, throttle) { var windowEl = angular.element($window); + var windowWidth = window.innerWidth; var unbindViewContentLoaded; var unbindIncludeContentLoaded; @@ -474,7 +475,15 @@ angular.module('hl.sticky', []) } // bind events - throttledResize = throttle(resize, $stickyElement.defaults.checkDelay, {leading: false}); + throttledResize = function(event) { + + var newWidth = window.innerWidth; + + if (width != newWidth) { + throttle(resize, $stickyElement.defaults.checkDelay, {leading: false})(arguments); + width = newWidth; + } + }; windowEl.on('resize', throttledResize); windowEl.on('scroll', drawEvent); @@ -687,4 +696,4 @@ angular.module('hl.sticky', []) } }; }; - }); \ No newline at end of file + }); From bad027edba8279f8e1deb49403c3d9b07f808466 Mon Sep 17 00:00:00 2001 From: "p.ivanov" Date: Wed, 9 Aug 2017 15:52:07 +0300 Subject: [PATCH 2/2] wrong var name fix --- js/angular-sticky.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/js/angular-sticky.js b/js/angular-sticky.js index 6ff0ade..5504a93 100755 --- a/js/angular-sticky.js +++ b/js/angular-sticky.js @@ -479,9 +479,9 @@ angular.module('hl.sticky', []) var newWidth = window.innerWidth; - if (width != newWidth) { + if (windowWidth != newWidth) { throttle(resize, $stickyElement.defaults.checkDelay, {leading: false})(arguments); - width = newWidth; + windowWidth = newWidth; } }; windowEl.on('resize', throttledResize);