Classes without a constructor didn't work

A class without a constructor were throwing an error while decoding.
This happened because the ReflectionMethod gave an exception if it was
missing. I've wrapped the method in a try/catch so this not longer
occurs.

I also renamed the root name for and XML encoded object to "encoded".

Author: harm-less

src/PE/Encoder.php

@@ -242,16 +242,21 @@ protected function _decodeNode($nodeName, $nodeData, EncoderOptions $options, En
 	}
 
 	protected function getRequiredConstructorVariables($className) {
-		$reflector = new \ReflectionMethod($className, '__construct');
-		$requiredVariables = $reflector->getParameters();
-
-		$arr = array();
-		foreach ($requiredVariables as $variable) {
-			if (!$variable->isOptional()) {
-				array_push($arr, $variable->getName());
+		try {
+			$reflector = new \ReflectionMethod($className, '__construct');
+			$requiredVariables = $reflector->getParameters();
+
+			$arr = array();
+			foreach ($requiredVariables as $variable) {
+				if (!$variable->isOptional()) {
+					array_push($arr, $variable->getName());
+				}
 			}
+			return $arr;
+		}
+		catch(\Exception $e) {
+			return array();
 		}
-		return $arr;
 	}
 
 

src/PE/Encoders/XmlEncoder.php

@@ -11,7 +11,7 @@
 
 class XmlEncoder extends Encoder {
 
-	const ROOT_NODE_NAME = 'tb';
+	const ROOT_NODE_NAME = 'encoded';
 
 	public function encode($object, EncoderOptions $options = null) {
 		$arr = parent::encode($object, $options);

tests/PE/Samples/Specials/AccessorMethodActionTypeNode.php

@@ -5,9 +5,6 @@
 class AccessorMethodActionTypeNode {
 
 	private $special;
-	function __construct() {
-
-	}
 
 	public function setSpecial($value) {
 		$this->special = $value;

tests/PE/Tests/Encoders/XmlEncoderTest.php

@@ -36,13 +36,13 @@ public function testEncodeDecode() {
 		$xmlString = trim(preg_replace('/\s+/', ' ', $encoded->saveXML()));
 
 		$this->assertEquals('<?xml version="1.0" encoding="UTF-8"?> '
-			. '<tb> '
+			. '<encoded> '
 			.   '<building type="house"> '
 			.     '<animals> '
 			.       '<animal type="cat" name="Cat"/> '
 			.     '</animals> '
 			.   '</building> '
-			. '</tb>', $xmlString);
+			. '</encoded>', $xmlString);
 
 		$decoded = $this->encoder()->decode($xmlString);
 		$this->assertArrayHasKey('building', $decoded);
@@ -65,11 +65,11 @@ public function testEncodeDecoded() {
 		$xmlString = trim(preg_replace('/\s+/', ' ', $encoded->saveXML()));
 
 		$this->assertEquals('<?xml version="1.0" encoding="UTF-8"?> '
-			. '<tb> '
+			. '<encoded> '
 			.   '<single-child> '
 			.     '<thing thingVar="hello world"/> '
 			.   '</single-child> '
-			. '</tb>', $xmlString);
+			. '</encoded>', $xmlString);
 
 		$decoded = $this->encoder()->decode($xmlString);
 		$this->assertArrayHasKey('single-child', $decoded);