The node children partly work

Author: harm-less

src/PE/Encoder.php

@@ -412,7 +412,7 @@ protected function _encode($object, EncoderNode $node, EncoderOptions $options,
 				$isIterated = $optionChildIteration !== null;
 				$childIteration = $optionChildIteration === null ? 1 : $optionChildIteration;
 
-				$getChildObjectsMethod = $child->getGetterMethod();
+				$getChildObjectsMethod = $child->getGetter()->getMethod();
 				if (!method_exists($object, $getChildObjectsMethod)) {
 					throw new EncoderException(sprintf('Getter method "%s" for node "%s" does not exist in class "%s"', $getChildObjectsMethod, $childNodeName, get_class($object)));
 				}

src/PE/Nodes/Children/NodeChildAccessor.php

@@ -10,6 +10,10 @@ function __construct($method) {
 		$this->method = $method;
 	}
 
+	public function getMethod() {
+		return $this->method;
+	}
+
 }
 
 ?>

src/PE/Nodes/Children/NodeChildGetter.php

@@ -0,0 +1,13 @@
+<?php
+
+namespace PE\Nodes\Children;
+
+class NodeChildGetter extends NodeChildAccessor {
+
+	function __construct($method) {
+		parent::__construct($method);
+	}
+
+}
+
+?>

src/PE/Nodes/EncoderNodeChild.php

@@ -3,10 +3,26 @@
 namespace PE\Nodes;
 
 use PE\Exceptions\EncoderNodeChildException;
+use PE\Nodes\Children\NodeChildGetter;
+use PE\Nodes\Children\NodeChildSetter;
 
 class EncoderNodeChild extends EncoderNodeVariable {
 
+	/**
+	 * @var string
+	 */
 	private $childNodeName;
+
+	/**
+	 * @var NodeChildSetter Setter of the child objects
+	 */
+	private $setter;
+
+	/**
+	 * @var NodeChildGetter Setter of the child objects
+	 */
+	private $getter;
+
 	private $isArray = true;
 	private $setAfterChildren = true;
 	private $setAfterAttributes = true;
@@ -26,6 +42,32 @@ public function getChildNodeName() {
 		return $this->childNodeName;
 	}
 
+	/**
+	 * @param NodeChildSetter $setter
+	 */
+	public function setter(NodeChildSetter $setter) {
+		$this->setter = $setter;
+	}
+	/**
+	 * @return NodeChildSetter
+	 */
+	public function getSetter() {
+		return $this->setter;
+	}
+
+	/**
+	 * @param NodeChildGetter $getter
+	 */
+	public function getter(NodeChildGetter $getter) {
+		$this->getter = $getter;
+	}
+	/**
+	 * @return NodeChildGetter
+	 */
+	public function getGetter() {
+		return $this->getter;
+	}
+
 	// @todo Figure out if this feature is still necessary. Because if you use a single node, can't we simply assume it isn't an array?
 	public function isArray($bool = null) {
 		if ($bool !== null) {
@@ -56,13 +98,13 @@ public function setAfterAttributes($bool = null) {
 	 * @return bool Returns true if the action succeeded and false when it couldn't find the child
 	 */
 	public function addChildrenToObject($target, $values) {
-		$methodName = $this->getSetterMethod();
+		$methodName = $this->getSetter()->getMethod();
 		if ($methodName === null) {
 			throw new EncoderNodeChildException(sprintf('Setter method (%s) for class "%s" does not exist', $this->getChildNodeName(), get_class($target)));
 		}
 		else if (method_exists($target, $methodName)) {
 			foreach ($values as $value) {
-				$target->$methodName($this->processValue($value));
+				$target->$methodName($value);
 			}
 		}
 		else {

tests/PE/Nodes/Farm/Buildings/AnimalsBuildingNode.php

@@ -2,17 +2,18 @@
 
 namespace PE\Nodes\Farm\Buildings;
 
+use PE\Nodes\Children\NodeChildGetter;
+use PE\Nodes\Children\NodeChildSetter;
 use PE\Nodes\EncoderNodeChild;
 
 class AnimalsBuildingNode extends CustomBuilding {
 
 	function __construct($nodeTypeName) {
 		parent::__construct($nodeTypeName);
 
-		$this->addChildNode(new EncoderNodeChild('animals', array(
-			'setter' => 'addAnimal',
-			'getter' => 'getAnimals'
-		)));
+		$animals = $this->addChildNode(new EncoderNodeChild('animals'));
+		$animals->setter(new NodeChildSetter('addAnimal'));
+		$animals->getter(new NodeChildGetter('getAnimals'));
 	}
 
 }

tests/PE/Nodes/Farm/FarmNode.php

@@ -2,6 +2,8 @@
 
 namespace PE\Nodes\Farm;
 
+use PE\Nodes\Children\NodeChildGetter;
+use PE\Nodes\Children\NodeChildSetter;
 use PE\Nodes\EncoderNode;
 use PE\Nodes\EncoderNodeChild;
 
@@ -10,10 +12,9 @@ class FarmNode extends EncoderNode {
 	function __construct() {
 		parent::__construct('farms', 'farm', '\\PE\\Samples\\Farm');
 
-		$this->addChildNode(new EncoderNodeChild('buildings', array(
-			'setter' => 'addBuilding',
-			'getter' => 'getBuildings'
-		)));
+		$buildings = $this->addChildNode(new EncoderNodeChild('buildings'));
+		$buildings->setter(new NodeChildSetter('addBuilding'));
+		$buildings->getter(new NodeChildGetter('getBuildings'));
 	}
 
 }