Overwriting the default type gave some problems

If the default type was overwritten the type with the same name could
not be added because it said it already existed which shouldn't be the
case

Author: harm-less

src/PE/Nodes/EncoderNode.php

@@ -112,7 +112,7 @@ public static function addNode(EncoderNode $node) {
 		// make this node the default one if no type has yet been specified
 		if (count(self::getNodeTypes($nodeName)) == 0) {
 			// set the default type name so it can be registered as a type
-			$node->typeName = $node->getDefaultType();
+			$node->typeName = self::DEFAULT_TYPE;
 			self::addNodeType($node);
 		}
 

tests/PE/Nodes/Specials/HasDefaultTypeNode.php

@@ -0,0 +1,19 @@
+<?php
+
+namespace PE\Nodes\Specials;
+
+use PE\Nodes\EncoderNode;
+use PE\Nodes\EncoderNodeChild;
+
+class HasDefaultTypeNode extends EncoderNode {
+
+	const NEW_DEFAULT_TYPE = 'should-be-the-default-type';
+
+	function __construct($nodeTypeName = null) {
+		parent::__construct('has-default-types', 'has-default-type', '\\PE\\Samples\\Specials', $nodeTypeName);
+	}
+
+	public function getDefaultType() {
+		return self::NEW_DEFAULT_TYPE;
+	}
+}

tests/PE/Nodes/Specials/HasDefaultTypeTypeNode.php

@@ -0,0 +1,10 @@
+<?php
+
+namespace PE\Nodes\Specials;
+
+class HasDefaultTypeTypeNode extends HasDefaultTypeNode {
+
+	function __construct() {
+		parent::__construct(HasDefaultTypeNode::NEW_DEFAULT_TYPE);
+	}
+}

tests/PE/Samples/Specials/HasDefaultType.php

@@ -0,0 +1,10 @@
+<?php
+
+namespace PE\Samples\Specials;
+
+class HasDefaultType {
+
+	function __construct() {
+
+	}
+}

tests/PE/Samples/Specials/HasDefaultTypeType.php

@@ -0,0 +1,10 @@
+<?php
+
+namespace PE\Samples\Specials;
+
+class HasDefaultTypeType {
+
+	function __construct() {
+
+	}
+}

tests/PE/Tests/Nodes/EncoderNodeTest.php

@@ -6,6 +6,7 @@
 use PE\Nodes\EncoderNode;
 use PE\Nodes\EncoderNodeChild;
 use PE\Nodes\EncoderNodeVariable;
+use PE\Nodes\Specials\HasDefaultTypeNode;
 use PE\Tests\Samples;
 
 class EncoderNodeTest extends Samples
@@ -150,6 +151,15 @@ public function testStaticAddNodeTypeWithoutNodeType() {
 		EncoderNode::addNodeType($this->nodeType());
 	}
 
+	public function testOverwrittenDefaultType() {
+		$hasDefaultTypeNode = $this->addHasDefaultTypeNode();
+		$this->addHasDefaultTypeTypeNode();
+
+		$this->assertTrue(EncoderNode::nodeTypeExists($hasDefaultTypeNode->getNodeName(), 'default'));
+		$this->assertTrue(EncoderNode::nodeTypeExists($hasDefaultTypeNode->getNodeName(), HasDefaultTypeNode::NEW_DEFAULT_TYPE));
+		$this->assertEquals(count(EncoderNode::getNodeTypes()), 2);
+	}
+
 	public function testStaticGetNodeTypeByObject() {
 		$this->addBuildingNode();
 		$houseNode = $this->addBuildingHouseNode();

tests/PE/Tests/Samples.php

@@ -25,6 +25,8 @@
 use PE\Nodes\Specials\AddAfterDecodeParentNode;
 use PE\Nodes\Specials\ClassLoaderNode;
 use PE\Nodes\Specials\EncoderNodeVariableApplyToSetterNode;
+use PE\Nodes\Specials\HasDefaultTypeNode;
+use PE\Nodes\Specials\HasDefaultTypeTypeNode;
 use PE\Nodes\Specials\NonArrayGetterMethodOnPurposeNode;
 use PE\Nodes\Specials\RequiredConstructorVariablesNode;
 use PE\Nodes\Specials\SingleChildNode;
@@ -43,6 +45,8 @@
 use PE\Samples\General\Thing;
 use PE\Samples\General\Things;
 use PE\Samples\Specials\EncoderNodeVariableApplyToSetter;
+use PE\Samples\Specials\HasDefaultType;
+use PE\Samples\Specials\HasDefaultTypeType;
 use PE\Samples\Specials\NonArrayGetterMethodOnPurpose;
 use PE\Samples\Specials\AccessorMethodActionTypeNode;
 use PE\Samples\Specials\SingleChild;
@@ -200,6 +204,20 @@ public function addNonArrayGetterMethodNode() {
 	}
 
 
+	public function getHasDefaultType() {
+		return new HasDefaultType();
+	}
+	public function addHasDefaultTypeNode() {
+		return EncoderNode::addNode(new HasDefaultTypeNode());
+	}
+	public function getHasDefaultTypeType() {
+		return new HasDefaultTypeType();
+	}
+	public function addHasDefaultTypeTypeNode() {
+		return EncoderNode::addNodeType(new HasDefaultTypeTypeNode());
+	}
+
+
 	public function getNonArrayGetterMethodOnPurpose() {
 		return new NonArrayGetterMethodOnPurpose();
 	}