Added unit tests for EncoderNodeChildren.php

Author: harm-less

src/PE/nodes/EncoderNodeChildren.php

@@ -2,6 +2,8 @@
 
 namespace PE\Nodes;
 
+use PE\Exceptions\EncoderNodeChildException;
+
 class EncoderNodeChildren {
 
 	/**
@@ -65,9 +67,9 @@ public function childExists($childName) {
 	public function addChildrenToObject($childName, $target, $values) {
 		$child = strtolower($childName);
 		$childNode = $this->getChild($child);
-		if ($childNode) {
-			return $childNode->addChildrenToObject($target, $values);
+		if (!$childNode) {
+			throw new EncoderNodeChildException(sprintf('Trying to add children to object, but the child "%s" could not be found', $childName));
 		}
-		return false;
+		return $childNode->addChildrenToObject($target, $values);
 	}
 } 

tests/PE/Tests/nodes/EncoderNodeChildrenTest.php

@@ -0,0 +1,75 @@
+<?php
+
+namespace PE\Tests\Nodes;
+use PE\Nodes\EncoderNodeChild;
+use PE\Nodes\EncoderNodeChildren;
+use PE\Tests\Samples;
+
+class EncoderNodeChildrenTest extends Samples {
+
+	protected function setUp() {
+		parent::setUp();
+		$this->_peApp = $this->nodeChildren();
+	}
+
+	/**
+	 * @return EncoderNodeChildren
+	 */
+	protected function nodeChildren() {
+		return new EncoderNodeChildren();
+	}
+
+	public function testConstructor() {
+		$nodeChildren = $this->nodeChildren();
+		$this->assertNotNull($nodeChildren);
+		$this->assertTrue($nodeChildren instanceof EncoderNodeChildren);
+	}
+
+	public function testAddChild() {
+		$nodeChildren = $this->nodeChildren();
+		$child = $nodeChildren->addChild(new EncoderNodeChild('test'));
+		$this->assertEquals($child, $nodeChildren->getChild('test'));
+
+		$this->assertFalse($nodeChildren->addChild($child));
+
+	}
+
+	public function testGetChild() {
+		$nodeChildren = $this->nodeChildren();
+		$child = $nodeChildren->addChild(new EncoderNodeChild('test'));
+		$this->assertEquals($child, $nodeChildren->getChild('test'));
+		$this->assertEquals($child, $nodeChildren->getChild('tEsT'));
+		$this->assertNull($nodeChildren->getChild('unknown'));
+	}
+
+	public function testGetChildren() {
+		$nodeChildren = $this->nodeChildren();
+		$this->assertEquals(array(), $nodeChildren->getChildren());
+		$child = $nodeChildren->addChild(new EncoderNodeChild('test'));
+		$this->assertEquals(array(
+			'test' => $child
+		), $nodeChildren->getChildren());
+	}
+
+	public function testChildExists() {
+		$nodeChildren = $this->nodeChildren();
+		$nodeChildren->addChild(new EncoderNodeChild('test'));
+		$this->assertTrue($nodeChildren->childExists('test'));
+		$this->assertFalse($nodeChildren->childExists('unknown'));
+	}
+
+	public function testAddChildrenToObject() {
+		$farmNode = $this->addFarmNode();
+		$farm = $this->getFarm(false, false);
+		$house = $this->getBuildingHouse();
+		$farmNode->addChildrenToObject('buildings', $farm, array(
+			$house
+		));
+		$this->assertEquals(array($house), $farm->getBuildings());
+	}
+	public function testAddChildrenToObjectWhenChildIsNotFound() {
+		$this->setExpectedException('\\PE\\Exceptions\\EncoderNodeChildException', 'Trying to add children to object, but the child "unknown" could not be found');
+		$nodeChildren = $this->nodeChildren();
+		$nodeChildren->addChildrenToObject('unknown', null, null);
+	}
+}