Skip to content

feat(components): remove ember-get-config #3277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 22 commits into
base: main-5.0.0
Choose a base branch
from
Open

feat(components): remove ember-get-config #3277

wants to merge 22 commits into from

Conversation

@aklkv
Copy link
Collaborator

@aklkv aklkv commented Oct 4, 2025 •
edited
Loading

📌 Summary

ember-get-config is problematic in vite world and doesn't work without a hack this hack will not be release and it is advised to move to appInstance lookup

This just does that for components and website (which was pretty strange usecase)

  • bonus I removed no longer needed ember-unique-id-helper-polyfill support for this feature in included ember-source > v4.4 - let me know if you want me to split it out

🛠️ Detailed description

📸 Screenshots

🔗 External links

Jira ticket: HDS-XXX
Figma file: [if it applies]

👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@aklkv aklkv self-assigned this Oct 4, 2025
@vercel
Copy link

vercel bot commented Oct 4, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Oct 28, 2025 11:53pm
hds-website Ready Ready Preview Oct 28, 2025 11:53pm

@aklkv aklkv changed the title Feat/ember get config feat(components): remove ember-get-config Oct 4, 2025
@aklkv aklkv marked this pull request as ready for review October 4, 2025 08:44
@aklkv aklkv requested a review from a team as a code owner October 4, 2025 08:44
@zamoore zamoore requested a review from a team as a code owner October 6, 2025 13:59
@zamoore zamoore force-pushed the main-5.0.0 branch 6 times, most recently from 686303f to 4b846d1 Compare October 10, 2025 16:35
@zamoore zamoore force-pushed the feat/ember-get-config branch from bddfb59 to 4ba8a23 Compare October 10, 2025 17:06
@zamoore zamoore added the release-candidate Publishes release candidates to npm label Oct 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025 •
edited
Loading

📦 RC Packages Published

Latest commit: 5e70b59

Published 3 packages

@hashicorp/design-system-codemods@0.5.2-rc-20251028235020

yarn up -C @hashicorp/design-system-codemods@rc

@hashicorp/design-system-components@5.0.0-rc-20251028235020

yarn up -C @hashicorp/design-system-components@rc

@hashicorp/flight-icons@4.0.0-rc-20251028235020

yarn up -C @hashicorp/flight-icons@rc

@aklkv aklkv force-pushed the feat/ember-get-config branch from 4ba8a23 to a5aa2b7 Compare October 17, 2025 10:33
@aklkv aklkv force-pushed the feat/ember-get-config branch from a5aa2b7 to bc6406f Compare October 17, 2025 10:36
zamoore and others added 20 commits October 28, 2025 15:15
@zamoore
init commit
ccfc247
@zamoore
HdsAdvancedTableTh Remove @isVisuallyHidden argument (#3210)
8c0269d
@zamoore
Fix service import deprecation (#3181)
14d7e3a
@zamoore
Remove deprecated HdsMenuPrimitive component (#3224)
1968a74
@zamoore
Remove unneeded sass-related dependencies (#3206)
8ae5fe6
@zamoore
HdsDropdownListItemInteractive - Remove deprecated @text argument (…
7677374 
…#3212)
@zamoore
HdsSideNav deprecations (#3230)
8cfc57b
@zamoore
Update ember-try matrix (#3202)
6240c1f
@zamoore @RobbieTheWagner
Update Ember version compatibility (#3264)
5eb8933 
Co-authored-by: Robbie Wagner <rwwagner90@gmail.com>
@zamoore
Deprecate HdsModal and HdsFlyout yielded subcomponents (#3222)
bb041a6
@zamoore
Remove deprecated ember-flight-icon lazyEmbed flag (#3272)
2494fae
@hashibot-hds @jorytindall @zamoore
Updated export of icons from Figma (#3269)
9911c57 
Co-authored-by: jorytindall <2200899+jorytindall@users.noreply.github.com>
Co-authored-by: Jory Tindall <jory.tindall@hashicorp.com>
@zamoore
Add changeset for volume-2 icon rename (#3276)
48a8d74
@zamoore @didoo
ApplicationState - Remove center alignment rule (#3205)
6b244e3 
Co-authored-by: Cristiano Rastelli <cristiano.rastelli@hashicorp.com>
@zamoore
Remove incorrect HdsCard invocation path (#3275)
05b9e81
@shleewhite @aklkv @zamoore
Upgrade ember-a11y-refocus to v5.1.0 (#3234)
8e67949 
Co-authored-by: shleewhite <lee.white@hahicorp.com>
Co-authored-by: Alexey Kulakov <uni_que@me.com>
@zamoore
Upgrade ember-stargate (#3268)
7f85840
@zamoore @alex-ju
Add ember-basic-dropdown as a peer dependency (#3282)
156a502 
Co-authored-by: Alex <alex-ju@users.noreply.github.com>
@zamoore
Upgrade @ember/render-modifiers (#3294)
d8150f4
@zamoore
Adds a11y guardrails in Dropdown ToggleIcon component
3cf60b9
@aklkv aklkv force-pushed the feat/ember-get-config branch from c1fc806 to a613281 Compare October 28, 2025 20:29
@aklkv aklkv force-pushed the feat/ember-get-config branch from a613281 to 5e70b59 Compare October 28, 2025 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zamoore zamoore zamoore left review comments

Assignees

@aklkv aklkv

Labels

packages/components release-candidate Publishes release candidates to npm showcase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aklkv @zamoore @hashibot-hds @shleewhite