feature(): Add TooManyArguments inspection to vb.net

Author: Wolfgang Janz

CleanCode/src/CleanCode/CleanCode.csproj

@@ -184,6 +184,8 @@
       <SubType>Code</SubType>
     </Compile>
     <Compile Include="Features\TooManyDependencies\TooManyDependenciesCheck.cs" />
+    <Compile Include="Features\TooManyMethodArguments\TooManyArgumentsHighlightingVb.cs" />
+    <Compile Include="Features\TooManyMethodArguments\TooManyMethodArgumentsCheckVb.cs" />
     <Compile Include="Features\TooManyMethodArguments\TooManyMethodArgumentsCheck.cs" />
     <Compile Include="Features\TooManyMethodArguments\TooManyArgumentsHighlighting.cs">
       <SubType>Code</SubType>
@@ -230,6 +232,7 @@
   <ItemGroup>
     <None Include="..\CleanCode.nuspec">
       <Link>CleanCode.nuspec</Link>
+      <SubType>Designer</SubType>
     </None>
     <None Include="packages.config" />
   </ItemGroup>
@@ -273,4 +276,8 @@
   <Import Project="..\packages\JetBrains.Psi.Features.test.Framework.106.0.20160818.164034\build\JetBrains.Psi.Features.test.Framework.Targets" Condition="Exists('..\packages\JetBrains.Psi.Features.test.Framework.106.0.20160818.164034\build\JetBrains.Psi.Features.test.Framework.Targets')" />
   <Import Project="..\packages\JetBrains.Build.Platform.Tasks.ThemedIconsPacker.2.0.20151217.1\build\JetBrains.Build.Platform.Tasks.ThemedIconsPacker.Targets" Condition="Exists('..\packages\JetBrains.Build.Platform.Tasks.ThemedIconsPacker.2.0.20151217.1\build\JetBrains.Build.Platform.Tasks.ThemedIconsPacker.Targets')" />
   <Import Project="..\packages\JetBrains.ReSharper.SDK.Internal.106.0.20160818.171542\build\JetBrains.ReSharper.SDK.Internal.Targets" Condition="Exists('..\packages\JetBrains.ReSharper.SDK.Internal.106.0.20160818.171542\build\JetBrains.ReSharper.SDK.Internal.Targets')" />
+  <PropertyGroup>
+    <PostBuildEvent>
+    </PostBuildEvent>
+  </PropertyGroup>
 </Project>

CleanCode/src/CleanCode/Features/TooManyMethodArguments/TooManyArgumentsHighlightingVb.cs

@@ -0,0 +1,30 @@
+using CleanCode;
+using CleanCode.Features.TooManyMethodArguments;
+using JetBrains.DocumentModel;
+using JetBrains.ReSharper.Feature.Services.Daemon;
+using JetBrains.ReSharper.Psi.VB;
+
+[assembly: RegisterConfigurableSeverity(TooManyArgumentsHighlightingVb.SeverityID, null, 
+    CleanCodeHighlightingGroupIds.CleanCode, "Too many arguments", "Too many arguments passed to a method.",
+    Severity.WARNING, false)]
+
+namespace CleanCode.Features.TooManyMethodArguments
+{
+    [ConfigurableSeverityHighlighting(SeverityID, VBLanguage.Name)]
+    public class TooManyArgumentsHighlightingVb : IHighlighting
+    {
+        internal const string SeverityID = "TooManyArguments";
+        private readonly DocumentRange documentRange;
+
+        public TooManyArgumentsHighlightingVb(string toolTip, DocumentRange documentRange)
+        {
+            ToolTip = toolTip;
+            this.documentRange = documentRange;
+        }
+
+        public DocumentRange CalculateRange() => documentRange;
+        public string ToolTip { get; }
+        public string ErrorStripeToolTip => ToolTip;
+        public bool IsValid() => true;
+    }
+}

CleanCode/src/CleanCode/Features/TooManyMethodArguments/TooManyMethodArgumentsCheckVb.cs

@@ -0,0 +1,30 @@
+using CleanCode.Resources;
+using CleanCode.Settings;
+using JetBrains.Application.Settings;
+using JetBrains.ReSharper.Daemon.Stages.Dispatcher;
+using JetBrains.ReSharper.Feature.Services.Daemon;
+using JetBrains.ReSharper.Psi.VB.Tree;
+using JetBrains.ReSharper.Psi.Tree;
+
+namespace CleanCode.Features.TooManyMethodArguments
+{
+    [ElementProblemAnalyzer(typeof(IMethodDeclaration), HighlightingTypes = new []
+    {
+        typeof(TooManyArgumentsHighlightingVb)
+    })]
+    public class TooManyMethodArgumentsCheckVb : ElementProblemAnalyzer<IMethodDeclaration>
+    {
+        protected override void Run(IMethodDeclaration element, ElementProblemAnalyzerData data, IHighlightingConsumer consumer)
+        {
+            var maxParameters = data.SettingsStore.GetValue((CleanCodeSettings s) => s.MaximumMethodParameters);
+            var parameterDeclarations = element.ParameterDeclarations;
+
+            if (parameterDeclarations.Count > maxParameters)
+            {
+                var highlighting = new TooManyArgumentsHighlightingVb(Warnings.TooManyMethodArguments,
+                    element.GetNameDocumentRange());
+                consumer.AddHighlighting(highlighting);
+            }
+        }
+    }
+}