Skip to content

Commit bd1f0da

Browse files
committed
fix: run procedure handler
1 parent b755661 commit bd1f0da

File tree

2 files changed

+13
-7
lines changed

2 files changed

+13
-7
lines changed

cmd/serve.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ to interact and monitor the Scroll Application`,
123123
snapshotService := snapshotServices.NewSnapshotService()
124124
coldStarter := services.NewColdStarter(portService, queueManager, snapshotService, scrollService.GetDir())
125125

126-
scrollHandler := handler.NewScrollHandler(scrollService, pluginManager, processLauncher, queueManager)
126+
scrollHandler := handler.NewScrollHandler(scrollService, pluginManager, processLauncher, queueManager, processManager)
127127
processHandler := handler.NewProcessHandler(processManager)
128128
scrollLogHandler := handler.NewScrollLogHandler(scrollService, logManager, processManager)
129129
scrollMetricHandler := handler.NewScrollMetricHandler(scrollService, processMonitor)

internal/handler/scroll_handler.go

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ type ScrollHandler struct {
1313
PluginManager ports.PluginManagerInterface
1414
ProcessLauncher ports.ProcedureLauchnerInterface
1515
QueueManager ports.QueueManagerInterface
16+
ProcessManager ports.ProcessManagerInterface
1617
}
1718

1819
type StartScrollRequestBody struct {
@@ -27,8 +28,14 @@ type StartProcedureRequestBody struct {
2728
Sync bool `json:"sync"`
2829
}
2930

30-
func NewScrollHandler(scrollService ports.ScrollServiceInterface, pluginManager ports.PluginManagerInterface, processLauncher ports.ProcedureLauchnerInterface, queueManager ports.QueueManagerInterface) *ScrollHandler {
31-
return &ScrollHandler{ScrollService: scrollService, PluginManager: pluginManager, ProcessLauncher: processLauncher, QueueManager: queueManager}
31+
func NewScrollHandler(
32+
scrollService ports.ScrollServiceInterface,
33+
pluginManager ports.PluginManagerInterface,
34+
processLauncher ports.ProcedureLauchnerInterface,
35+
queueManager ports.QueueManagerInterface,
36+
processManager ports.ProcessManagerInterface,
37+
) *ScrollHandler {
38+
return &ScrollHandler{ScrollService: scrollService, PluginManager: pluginManager, ProcessLauncher: processLauncher, QueueManager: queueManager, ProcessManager: processManager}
3239
}
3340

3441
// @Summary Get current scroll
@@ -125,10 +132,9 @@ func (sl ScrollHandler) RunProcedure(c *fiber.Ctx) error {
125132
}
126133

127134
command := requestBody.Process
128-
_, err = sl.ScrollService.GetCommand(command)
129-
130-
if err != nil {
131-
c.SendString("Command not found")
135+
process := sl.ProcessManager.GetRunningProcess(command)
136+
if process == nil {
137+
c.SendString("Running process not found")
132138
return c.SendStatus(400)
133139
}
134140

0 commit comments

Comments
 (0)